-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCRE2: Explicitly specify cmake c standard #19726
PCRE2: Explicitly specify cmake c standard #19726
Conversation
This comment has been minimized.
This comment has been minimized.
recipes/pcre2/all/conanfile.py
Outdated
# Fix for error: 'for' loop initial declarations are only allowed in C99 or C11 mode | ||
tc.variables["CMAKE_C_STANDARD"] = "99" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to PCRE2Project/pcre2#193:
- it's a recent change (PCRE2Project/pcre2@1c41a5b), so it shouldn't be forced for old versions
- it won't be needed for upcoming versions since it has been fixed upstream by build: make the C99 requirement explicit PCRE2Project/pcre2#193
Therefore I would recommend to patch impacted versions instead (10.40 & 10.42 I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, thanks for the feedback 👍
I've replaced this with a patch for the 10.42 version instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the patch so that it now cleanly applies to both 10.40 and 10.42
ae5dff0
to
3810772
Compare
This comment has been minimized.
This comment has been minimized.
3810772
to
6172178
Compare
This comment has been minimized.
This comment has been minimized.
Please remember to sign the CLA so that your contribution can be merged, thanks! :) |
I've attempted to sign it twice but it appears to be stuck pending |
6172178
to
e386bff
Compare
This comment has been minimized.
This comment has been minimized.
e386bff
to
b26e121
Compare
This comment has been minimized.
This comment has been minimized.
b26e121
to
efee488
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Specify library name and version: pcre2/10.42
Fixes #19725