ci: catch duplicate YAML keys and formatting issues in the GameDB #6134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The GameDB linter will now fail over duplicate keys (this is a violation as per the yaml spec) as well as formatting errors
Rationale behind Changes
PyYAML does not fail over this yaml/pyyaml#165 recently we merged some changes that got hit by this.
In practice this effectively eliminates one of the entries as the one encountered first wins.
Suggested Testing Steps
Check out the last 3 commits here, xTVaser#112 it failed when it should have and passed when everything was alright.
I'm using prettier to do the formatting, to do so locally you'll want to:
npm install -g prettier prettier --write ./bin/resources/GameIndex.yaml # alternatively just: npx prettier --write ./bin/resources/GameIndex.yaml