Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS: Rework of PCRTC code #7602

Merged
merged 3 commits into from
Feb 11, 2023
Merged

GS: Rework of PCRTC code #7602

merged 3 commits into from
Feb 11, 2023

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Dec 17, 2022 •
edited
Loading

Description of Changes

Rewrite the PCRTC code to make more sense and not look quite so gross.

Rationale behind Changes

Was gross, had flaws, needed fixing.

Suggested Testing Steps

I guess check offsets on the screen n stuff, and games which make use of the positioning such as DmC and WipEout Fusion.

  • Add changes to hardware renderer
  • Handle wrapping around 2048
  • Reset framebuffer offsets when reading from Software
  • Readd feedback circuit
  • Fix Anti-Blur when screen offsets is enabled
  • Make sure no-interlace patches work (ugh)
  • Tidy up code

@refractionpcsx2 refractionpcsx2 marked this pull request as draft December 17, 2022 17:33
@Florin9doi Florin9doi mentioned this pull request Dec 20, 2022
Open
@refractionpcsx2 refractionpcsx2 force-pushed the gs_pcrtcrewrite branch 4 times, most recently from dbe341c to 75c24b4 Compare February 3, 2023 17:51
@refractionpcsx2 refractionpcsx2 force-pushed the gs_pcrtcrewrite branch 2 times, most recently from fbc0e75 to 7ca6400 Compare February 9, 2023 01:09
@refractionpcsx2 refractionpcsx2 force-pushed the gs_pcrtcrewrite branch 3 times, most recently from 2a9d10c to 6abb35d Compare February 9, 2023 02:07
@refractionpcsx2 refractionpcsx2 changed the title GS: Rework of PCRTC code [Heavily WIP] GS: Rework of PCRTC code Feb 9, 2023
@refractionpcsx2
Copy link
Member Author

Okay This should be done now, it should be ready for testing.

@refractionpcsx2 refractionpcsx2 marked this pull request as ready for review February 9, 2023 02:08
@refractionpcsx2 refractionpcsx2 force-pushed the gs_pcrtcrewrite branch 2 times, most recently from adb6d67 to a1ad216 Compare February 10, 2023 23:17
@refractionpcsx2 refractionpcsx2 force-pushed the gs_pcrtcrewrite branch 7 times, most recently from a9dac28 to 3b12f0a Compare February 11, 2023 18:32
@refractionpcsx2 refractionpcsx2 merged commit 73abae8 into master Feb 11, 2023
@refractionpcsx2 refractionpcsx2 deleted the gs_pcrtcrewrite branch February 11, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

Assignees
No one assigned
Labels
GameDB GS: Direct3D 11 GS: Direct3D 12 GS: Hardware GS: Metal GS: OpenGL GS: Software GS: Vulkan GS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refractionpcsx2 @JordanTheToaster @lightningterror