Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme installation rules #156

Conversation

przemekhernik
Copy link
Contributor

Description

Since the project has been moved to PHPCSStandards organization, we need start updating docs. I feel that the most important are installation rules, so I've updated composer commands to use the new version. It's not too much, but at least something to start :)

Suggested changelog entry

No need for changelog entry.

Related issues/external references

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemekhernik I appreciate that you are trying to contribute to the project, but you are basing this PR on outdated information.

The change you are proposing was originally already made in the repo and has been reverted.

In contrast to earlier information, arrangements have been made to allow the package to continue under its original name on Packagist.

The information in the "The future of" post in the squizlabs repo as well as in this repo was updated to reflect this last week and this information is also very explicitly included in the release notes of the 3.8.0 release.

I'm going to close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants