-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer: revert package name change #135
Conversation
⚠️ **_To be merged once the Packagist edit has been made._**⚠️ This reverts commit f6dc841 and updates the information in the changelog for the 3.8.0 release. **Users who already changed the package name in _their_ `composer.json` dependencies, should switch back to the original package name.** Refs: * See [the conversation from this comment down](squizlabs/PHP_CodeSniffer#3932 (comment)). Closes 113, 114
67b4f32
to
5194c9c
Compare
This PR has been marked as a "breaking Change", though it really is an "unbreaking change". In the mean time, everything has been lined up, it is only as this is a "protected" package that the change on Packagist hasn't been made yet as it needs to be done by a Packagist admin. With that in mind, I'm going to merge this now anyway. |
…p_codesniffer (closes #2)
Follow up on 143 In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135). Sorry for the confusion and thank you for understanding.
Out of curiosity... will the phpcsstandards/php_codesniffer package be removed in the future... or will the duality exist forever? Sorry if it has been decided elsewhere, I may have missed it (though i'm trying to follow the relevant discussions). Ciao :-) PS: Edited, wrong link! |
@stronk7 I will likely mark it as abandoned and point to the original package name as its replacement. Not sure it can even be removed. |
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135).
* refactor: Require PHP 8.0; Bump all dependencies; Update workflow for PHP 8 requirement including newer versions PHP * refactor: Update code to PHP 8.0 using rector; Upgrade progressbar to show current url * refactor: Improving for PHP 8.0 support * fix: Add missing entry in known endpoints to avoid losing ProjectProjectProgressReports
Improved Github Actions test coverage Removed momentary usage of putenv() during the .env load process when using vlucas/phpdotenv Removed momentary usage of putenv() during the .env load process when using symfony/dotenv >= 5.1.0 Improved the Adapter code that uses vlucas/phpdotenv and symfony/dotenv
Previous namespace is abandoned.
Description
This reverts commit f6dc841 and updates the information in the changelog for the 3.8.0 release.
Users who already changed the package name in their
composer.json
dependencies, should switch back to the original package name.Refs:
Closes #113, #114, #116