-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move phpcs from squizlabs to phpcsstandards #83
Move phpcs from squizlabs to phpcsstandards #83
Conversation
PHP_Codesniffer is being abandoned by squizlabs. See: squizlabs/PHP_CodeSniffer#3932 (old org) PHPCSStandards/PHP_CodeSniffer#109 (new org) So it has been moved (copied, not transferred, not good, squizlabs) to the PHPCSStandards organisation. So this PR just moves us to start using the new organisation. Let's see how things evolve. It would be so great if the new one gets some support... (right now it's a 1-person project, basically).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=========================================
Coverage 96.17% 96.17%
Complexity 543 543
=========================================
Files 23 23
Lines 1542 1542
=========================================
Hits 1483 1483
Misses 59 59 ☔ View full report in Codecov by Sentry. |
Any chance Martin could be convinced to sponsor? 😃 https://github.com/sponsors/PHPCSStandards I'll definitely be asking my org if we can do something too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Eloy! Looks spot-on. Moving this forward!
Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package. In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted. I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub. Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday. |
Grrr! :-P Thanks for the heads up, @jrfnl (I was following the discussion). I'm not sure to understand which is the advantage of keeping the old "organisation" name (non-matching the real one). But we are ok, will keep using it (reverting this). Ciao :-) |
Well, there are two advantages:
|
Thanks @jrfnl , I'll continue asking @ PHPCSStandards/PHP_CodeSniffer#135 , things are moving so quickly that better share things in the canonical issues and prs. |
For the records, this PR has been "reverted". We are back to the Also, bumped to v3.8.0, just released. Ciao :-) |
PHP_Codesniffer is being abandoned by squizlabs. See:
squizlabs/PHP_CodeSniffer#3932 (old org) PHPCSStandards/PHP_CodeSniffer#109 (new org)
So it has been moved (copied "manually", not transferred, not good, squizlabs) to the PHPCSStandards organisation.
So this PR just moves us to start using the new organisation. Let's see how things evolve. It would be so great if the new one gets some support... (right now it's a 1-person project, basically).