Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOLVING + RESOLVING2 constants (Calculation/Calculation.php:4148) #1161

Closed
otuhacek opened this issue Sep 16, 2019 · 8 comments
Closed

RESOLVING + RESOLVING2 constants (Calculation/Calculation.php:4148) #1161

otuhacek opened this issue Sep 16, 2019 · 8 comments

Comments

@otuhacek
Copy link

Hi,
I just went into some problem when exporting some content on AC99 field. It complains of redefining RESOLVING2 constant multiple times, which triggered PHP Notice. Is this piece of code meant to be there or is it just something from previous testing?

Thanks

resolving

@pedrofsantoscom
Copy link

I also have the same notice. Besides the notice it runs without a problem.
This happens on a file created that has 22-29 sheets, and on each of those sheets column A has ~1000 rows and each row on col A has a very long expression (7000 characters long).

image

@stale
Copy link

stale bot commented Jan 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Jan 4, 2020
@stale stale bot closed this as completed Jan 11, 2020
@jonnylink
Copy link
Contributor

This is still an issue

@jonnylink
Copy link
Contributor

This is from this commit: https://github.com/jonnylink/PhpSpreadsheet/commit/0b387e767e99a9042886ea673d9b9905c7951e87

It does in fact look like code that was simply there to test, since there are no other references to the constant RESOLVING or RESOLVING2 in the codebase. I'm going to make a PR to remove that broken code.

@jonnylink jonnylink mentioned this issue Jan 16, 2020
5 tasks
@Benjiiii
Copy link

Facing same issue

@woganmay
Copy link

Just had this come up in production now for the first time. Definitely still an issue.

@jonnylink
Copy link
Contributor

jonnylink commented Jan 24, 2020

Might want to comment on or thumbs up the PR (#1328) if you're having this issue. Not sure anyone is checking closed issues.

@PowerKiKi please let me know if there's anything else needed to help get this bug fix merged.

PowerKiKi pushed a commit that referenced this issue Jan 24, 2020
Removed broken unused code that tried to set a constant multiple times.

Fixes #1161
Closes #1328
@oleibman
Copy link
Collaborator

Fixed by PR #1328 in February 2020.

@oleibman oleibman removed the stale label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants