Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX for issue #1161 #1328

Merged
merged 3 commits into from
Jan 24, 2020
Merged

BUGFIX for issue #1161 #1328

merged 3 commits into from
Jan 24, 2020

Conversation

jonnylink
Copy link
Contributor

@jonnylink jonnylink commented Jan 16, 2020

This is:

- [x] a bugfix (#1161)
- [ ] a new feature

Checklist:

  • Changes are covered by unit tests — No. Removed code that was never covered in tests and shouldn't have been there in the first place. Nothing to test.
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change
  • Documentation is updated as necessary — no not necessary

Why this change is needed?

As noted in #1161 there was some test code left in the calculation.php file. This would only show up on larger files, so it hasn't been prevalent, but it should be removed. There are no references to the constants being set. Even if they were, it's bad practice to set constants in code. Here it's in a loop and also in a simple if/else block.

@mostafatalebi
Copy link

May I know when we are going to have this commit released? (it is merged with master but not release-tagged).

@PowerKiKi
Copy link
Member

That was released in https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.11.0 back in March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants