Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML writer <meta> generator #312

Closed
criztovyl opened this issue Jan 1, 2018 · 3 comments
Closed

HTML writer <meta> generator #312

criztovyl opened this issue Jan 1, 2018 · 3 comments

Comments

@criztovyl
Copy link
Contributor

This is:

- [ ] a bug report
- [x] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

The produced HTML includes a PhpSpreadsheet as a generator.

What is the current behavior?

It's only included as a HTML comment.

$html .= '<!-- Generated by Spreadsheet - https://github.com/PHPOffice/Spreadsheet -->' . PHP_EOL;

@PowerKiKi
Copy link
Member

Sounds like a good idea, according to spec. I'd accept a PR for that.

It should not include the version (too hard to get it right for little benefits), but it should contains either the project name, the package name or the URL. I am not sure which would make more sense...

  • PhpSpreadsheet
  • phpoffice/phpspreadsheet
  • https://github.com/PHPOffice/Spreadsheet

?

@criztovyl
Copy link
Contributor Author

I'd vote for the second, although the first one meight already be unique enough. I just like the creator/package notation.

@PowerKiKi
Copy link
Member

OK for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants