Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #312: HTML Writer creates a generator meta tag #362

Closed
wants to merge 2 commits into from

Conversation

cwild
Copy link
Contributor

@cwild cwild commented Feb 7, 2018

This is:

- [ ] a bugfix
- [x] a new feature

An implementation for #312

Checklist:

Why this change is needed?

Copy link
Contributor

@criztovyl criztovyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I would maybe change the - to a , .

@cwild
Copy link
Contributor Author

cwild commented Feb 8, 2018

Thank you for your feedback, I have made the suggested change @criztovyl

Copy link
Contributor

@criztovyl criztovyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, would merge.

@PowerKiKi PowerKiKi closed this in 608a2ed Feb 11, 2018
Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants