[Bug] Fee calculation / maybe add a [Feature Request] Subtract Fee From Amount #2196
Comments
This was referenced Apr 27, 2021
furszy
added a commit
that referenced
this issue
Jun 13, 2021
…ate[Fund]Transaction a1bd590 [Doc] Document subtract-fee-from-amount RPC changes in the release notes (random-zebra) 6589429 wallet: first step generalizing CRecipient and ShieldedRecipient usage creating CRecipientBase class. (furszy) 1239506 [QA] Properly test change position in fundraw with sffa (random-zebra) cc9ff09 [RPC] Add fSubtractFeeFromAmount to shieldsendmany (random-zebra) 65d3a80 [Refactoring] Subtract fee from destination when building shield tx (random-zebra) cba898b [Refactoring] SendManyRecipient: use CRecipient for taddr + add sffa (random-zebra) 6fff9f5 [RPC] Add fSubtractFeeFromAmount to sendmany (transparent) (random-zebra) 7e30e3f [MOVE-ONLY] Move fundrawtransaction to rpcwallet (random-zebra) 499d62a [Tests] Add functional test for sffa in fundrawtransaction (random-zebra) 523b24d Subtract fee from amount (random-zebra) Pull request description: Add a feature requested many times (#894, #1079, #2196, ...) Allow the user to deduct the fee from one or more of the transaction recipient amounts. The most common use-case is when sending the whole balance, or a selection of UTXOs, without getting any change back. This is already possible by selecting "after-fee-amount" in coin-control, but such metod is not user-friendly (e.g. in case of shield recipients, to get the correct value, the destinations must already be filled before opening coin-control and copying the "after-fee" value). Plus, this workaround is only available in the GUI. The subtract-fee option makes it easier, and enables it via the cli as well. Here it's exposed only to the RPC, both for transparent and shield recipients: - `sendtoaddress` - `sendmany` - `shieldsendmany` - `fundrawtransaction` GUI connection will be added in a successive PR (which will close those issues). Last commit is coming from bitcoin#10294 Built on top of: - [x] #2337 ACKs for top commit: furszy: rebase + cherry-pick utACK a1bd590. Fuzzbawls: ACK a1bd590 Tree-SHA512: 7ed78f6ab8f1e9300d1468242e66016a4e1867f413256de23b7a60e103c2b628cdadcfc7998e8a7b252a7c2817d45261be108fad0eaa34d5ff892052c09b6e60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Case 1.
When sending form multiple T inputs (coin control) to S, usually fee is under calculated and wallet will notify about such "insufficient balance", to correct, re-open coin control window and copy new "after fee value" and works
Case 2.
When sending all multiple T inputs to S, fee over-calculated, send no problem but dust goes back to change address.
Fix as a feature, like in case of other crypts CRW, SYS add an option to send "subtract fee from amount".
For example you have 1.53427648 and try to send all 1.53427648, you need to calc the fee via coin control window and send less that fee (that could be calculate wrong see Case 1,2)
In case of "subtract fee from amount" checkbox, you enter what you want to send and agree destination will receive that mins fee calculated, so you would know what will arrive at destination only via confirmation window.
Visual from SYS
And confirmation window
The text was updated successfully, but these errors were encountered: