[GUI] Add GUI controls for subtract-fee-from-amount #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202104_subtractfee-GUI
branch
from
f9eee29 to
d8e47e1
Compare
random-zebra
added
the
Needs Release Notes
random-zebra
force-pushed
the
202104_subtractfee-GUI
branch
2 times, most recently
from
71f2329 to
2255df7
Compare
random-zebra
force-pushed
the
202104_subtractfee-GUI
branch
2 times, most recently
from
cb6710c to
cf2311e
Compare
random-zebra
force-pushed
the
202104_subtractfee-GUI
branch
2 times, most recently
from
0c14464 to
0646b46
Compare
|
Rebased on master, now that #2341 is merged. Ready for review. |
furszy
reviewed
Jul 5, 2021
There was a problem hiding this comment.
Worked a bit on this here furszy@dd40114, some styling improvements to the checkbox for the light and dark themes:
- Aligned the checkbox checked/unchecked text color and check image to the screen styling. So the action does not receive a higher degree of screen focus than the recipient edit boxes.
- Added checkbox hover selector state.
Side from that, backend process wise, working good 👍 .
When we get some time in-between the priority path, will work on the submenu styling of the dark theme with @Neoperol in another PR. It shouldn't be having a white background.
We will make the 'subtractFeeFromAmount' a checkable button in the menu for multiple recipient rows
Visible when single recipient. Its checked state returns whether or not to subtract the fee from the recipient amount. SendMultiRow::toggleSubtractFeeFromAmount is not connected for now. It will be connected with the contextual menu, to set per-recipient subtract-fee-from-amount, when there are multiple rows.
…dark themes. * Aligned the checkbox checked/unchecked text color and check image to the screen styling. * Added checkbox hover selector state.
random-zebra
force-pushed
the
202104_subtractfee-GUI
branch
from
0646b46 to
3e860c5
Compare
|
Rebased on master, picked @furszy's styling commit, and added one more commit for the confirmation dialog. |
furszy
approved these changes
Jul 16, 2021
Fuzzbawls
approved these changes
Jul 18, 2021
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2341.
As per title, add controls for this feature in the graphical interface.
For the moment, it's a simple checkbox, which is visible in case of single recipient.
The confirmation dialog shows the difference in the "total amount" (paid) when the fee is subtracted, or not, from the recipient amount (in the example, sending
1.00 PIV).When there are multiple recipients, the checkbox is hidden, and controlled by a checkable button inside the contextual menu.
Maybe this is not very intuitive, or pretty, but it does the job.
Later on, possibly with the help of @Neoperol, we can design a better placement for these controls.
Closes #894
Closes #2196
Obviously based on top of
which must be reviewed before this one.