constant propagation support #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 93.01% 93.01% -0.01%
==========================================
Files 40 40
Lines 14428 14468 +40
==========================================
+ Hits 13420 13457 +37
- Misses 1008 1011 +3
Continue to review full report at Codecov.
|
riederm
force-pushed
the
391-const-references-in-case-statements-not-supported-segfault-during-compilation
branch
from
01f0e53 to
85e7514
Compare
ghaith
reviewed
Jun 20, 2022
testcases: - constants & const-expressions used as initial values - constants & const-expressions used in case-statement - constants & const-expressions used in array-declaration
done - added correctness tests |
ghaith
reviewed
Jun 21, 2022
tests/correctness/constants.rs
Outdated
| gF : LREAL := cF; | ||
| END_VAR | ||
|
|
||
| PROGRAM main : DINT |
ghaith
reviewed
Jun 21, 2022
tests/correctness/constants.rs
Outdated
| let src = r#" | ||
| VAR_GLOBAL CONSTANT | ||
| cI : DINT := 2 * 5; | ||
| cB : BOOL := (CI-5 = 5); |
ghaith
approved these changes
Jun 21, 2022
ghaith
deleted the
391-const-references-in-case-statements-not-supported-segfault-during-compilation
branch
riederm
added a commit
that referenced
this pull request
Jun 21, 2022
added a test that shows that constants are propagated even in ranged-type's limits, so even if you use (const-)expressions (a+b) to define the limits of a ranged type, the const-expressions will be evaluated during compile time and the result will be used. - as in contrast we would do this calculation all the time at runtime. the behavior was introduced in PR #504 (016328) fixes #350
riederm
added a commit
that referenced
this pull request
Jun 21, 2022
added a test that shows that constants are propagated even in ranged-type's limits, so even if you use (const-)expressions (a+b) to define the limits of a ranged type, the const-expressions will be evaluated during compile time and the result will be used. - as in contrast we would do this calculation all the time at runtime. the behavior was introduced in PR #504 (016328) fixes #350
ghaith
pushed a commit
that referenced
this pull request
Jun 22, 2022
added a test that shows that constants are propagated even in ranged-type's limits, so even if you use (const-)expressions (a+b) to define the limits of a ranged type, the const-expressions will be evaluated during compile time and the result will be used. - as in contrast we would do this calculation all the time at runtime. the behavior was introduced in PR #504 (016328) fixes #350
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when generating an expression we check if this may refer to a constant
expression and rather generate it's initial value instead of a
reference to the global variable.
fixes #391 and #291