constant propagation in ranged type limits #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a test that shows that constants are propagated even in ranged-type's limits, so even if you use (const-)expressions (a+b) to define the limits of a ranged type, the const-expressions will be evaluated during compile time and the result will be used. - as in contrast we would do this calculation all the time at runtime. the behavior was introduced in PR #504 (016328) fixes #350
riederm
force-pushed
the
350-optimization-using-const-expression-in-sub-range-statements-should-resolve-constant-expressions-in-codegen
branch
from
12d0580 to
e369a37
Compare
|
see attached issue, previosuly we generated whole lot of stuff for the call to the check-range function. %call = call i16 @CheckRangeSigned(i16 5, i16 0, i16 8)
^^^^^^ ^^^^^ ^^^^^ |
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 40 40
Lines 14468 14468
=======================================
Hits 13461 13461
Misses 1007 1007 Continue to review full report at Codecov.
|
ghaith
approved these changes
Jun 22, 2022
…-sub-range-statements-should-resolve-constant-expressions-in-codegen
ghaith
deleted the
350-optimization-using-const-expression-in-sub-range-statements-should-resolve-constant-expressions-in-codegen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a test that shows that constants are propagated even in
ranged-type's limits, so even if you use (const-)expressions (a+b)
to define the limits of a ranged type, the const-expressions
will be evaluated during compile time and the result will be used.
runtime.
the behavior was introduced in PR #504 (016328)
fixes #350