Nacho/cleanup 3rdparty cmake #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now run cmake and check the compiler actually supports eigen. Before it was a raw copy-paste of the code
This is to make sure that FetchContent_Declare has the SYSTEM flag avaialbe. This improves the superbuild usage in general
This is the main disadvantage of this whole change
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from the superbuild patter of cmake, build, and install for header only libraries
This slow down a bit the CMake time. But at least runs CMake through all dependencies, making sure at configure time, that the compiler can actually build the library.
Of course, this simplifies and reduce by a big margin the portion of code we had to maintain
The only real disadvantage is that now the minimum required version when using super build is cmake 3.25, check the SYSTEM flag.