Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to change the sequence parameter to a
str
instead of anint
. This allows more flexibility when, for example, using a dataset like HeliPR (dataloader coming soon):Here, there are four different sensors available for each recording. With this, we could pass the desired sensor as the sequence parameter:
Passing a KITTI sequence ID will still work (and is anyway internally converted to a string):
Otherwise, we have to pass the full path
/path/to/HeLiPR/Roundabout01/LiDAR/Aeva
asdata_dir
, and this becomes messy since the reference poses the dataloader has to read in a parent directory in/path/to/HeLiPR/Roundabout01/LiDAR_GT
.What do you guys think @nachovizzo @tizianoGuadagnino?