Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string for sequence #303

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Use string for sequence #303

merged 2 commits into from
Mar 26, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Mar 26, 2024

I would like to change the sequence parameter to a str instead of an int. This allows more flexibility when, for example, using a dataset like HeliPR (dataloader coming soon):

image

Here, there are four different sensors available for each recording. With this, we could pass the desired sensor as the sequence parameter:

kiss_icp_pipeline --dataloader helipr /path/to/HeLiPR/Roundabout01 -v -s Aeva

Passing a KITTI sequence ID will still work (and is anyway internally converted to a string):

kiss_icp_pipeline --dataloader kitti /path/to/kitti-odometry/dataset -s 0

Otherwise, we have to pass the full path /path/to/HeLiPR/Roundabout01/LiDAR/Aeva as data_dir, and this becomes messy since the reference poses the dataloader has to read in a parent directory in /path/to/HeLiPR/Roundabout01/LiDAR_GT.

What do you guys think @nachovizzo @tizianoGuadagnino?

Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, I think it will generalize the sequence param. We basically use it just for KITTI while it can be useful also in other places where the sequence is not an int.

@nachovizzo nachovizzo merged commit b19cb01 into main Mar 26, 2024
17 checks passed
@nachovizzo nachovizzo deleted the benedikt/make_sequence_a_string branch March 26, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants