Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXCLUDE_FROM_ALL goes into the FetchContent_Declare #328

Merged
merged 27 commits into from
Apr 17, 2024
Merged

EXCLUDE_FROM_ALL goes into the FetchContent_Declare #328

merged 27 commits into from
Apr 17, 2024

Commits on Apr 16, 2024

  1. EXCLUDE_FROM_ALL goes into the FetchContent_Declare so that we can use 

    MakeAvailable and let cmake do is thing
    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9542abb View commit details
    Browse the repository at this point in the history

  2. Getting closer, now SYSTEM flag is not FetchContent_Declare

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    aedac45 View commit details
    Browse the repository at this point in the history

  3. Now it should be done

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    45e1f4e View commit details
    Browse the repository at this point in the history

  4. Final cleaning

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    faeba7a View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. TO BE REVERTED -> Remove personal repos

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4a5d165 View commit details
    Browse the repository at this point in the history

  2. lets see if sophus got fixed, otherwise revert

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3215d29 View commit details
    Browse the repository at this point in the history

  3. Try again other ciao ciao

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    54386c4 View commit details
    Browse the repository at this point in the history

  4. Revert "TO BE REVERTED -> Remove personal repos" 

    This reverts commit 4a5d165.
    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d44a092 View commit details
    Browse the repository at this point in the history

  5. TO BE REVERTED -> Remove personal repos

    @tizianoGuadagnino @benemer
    tizianoGuadagnino authored and benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a156481 View commit details
    Browse the repository at this point in the history

  6. Apply sophus patch

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3b11a28 View commit details
    Browse the repository at this point in the history

  7. Format

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d1a4918 View commit details
    Browse the repository at this point in the history

  8. Add back todo

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8b932d6 View commit details
    Browse the repository at this point in the history

  9. Fix patch file not found

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2009c5c View commit details
    Browse the repository at this point in the history

  10. I finally use pre-commit :)

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9484f18 View commit details
    Browse the repository at this point in the history

  11. patch got corrupted

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9113340 View commit details
    Browse the repository at this point in the history

  12. Let's see if this path passes pre-commits and the build

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    528d196 View commit details
    Browse the repository at this point in the history

  13. Back to original patch

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    809f71c View commit details
    Browse the repository at this point in the history

  14. remove whitespace

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ab1f9f5 View commit details
    Browse the repository at this point in the history

  15. Ignore patch in pre-commit eof check

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    daf19ea View commit details
    Browse the repository at this point in the history

  16. Try this for Windows

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3f42610 View commit details
    Browse the repository at this point in the history

  17. Next try

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6ca8fdd View commit details
    Browse the repository at this point in the history

  18. Revert up to "TO BE REVERTED -> Remove personal repos" 

    This reverts commit a156481.
    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    88cc2a7 View commit details
    Browse the repository at this point in the history

  19. Remove these, will be separate PR

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c1491c0 View commit details
    Browse the repository at this point in the history

  20. Remove personal repos

    @benemer
    benemer committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    91deba3 View commit details
    Browse the repository at this point in the history

  21. Revert "TO BE REVERTED -> Remove personal repos" 

    This reverts commit a156481.
    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f50e773 View commit details
    Browse the repository at this point in the history

  22. Add guarded cmake version check, will validate on dummy project

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    86f3f96 View commit details
    Browse the repository at this point in the history

  23. Mentally revert to what I did when I started this yesterday

    @tizianoGuadagnino
    tizianoGuadagnino committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    754863b View commit details
    Browse the repository at this point in the history