Changed hash function in preprocessing to be consistent with voxel map hash #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulfer80
requested review from
nachovizzo,
benemer and
tizianoGuadagnino
as code owners
nachovizzo
approved these changes
May 14, 2024
benemer
approved these changes
May 14, 2024
|
@tizianoGuadagnino good to merge? |
tizianoGuadagnino
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I would like to pinpoint small "bug". Hash function in preprocessing isn't consistent with voxel map hash.
This shouldn't change behavior of pipeline but could potentionally improve the speed a little. Hash function should have been made of prime numbers, where 19349663 isn't prime. This PR should fix it.
Thanks for your hard work and your willingness to improve this open source project every day 👌.