Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcap reader: Use extracted topic #353

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

benemer
Copy link
Member

@benemer benemer commented Jul 2, 2024

If no topic is provided, the self.check_topic is supposed to extract it, for example, if there is only one message of type PointCloud2. However, we did not pass the inferred topic. This is the fix.

Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come 🤔 I thought it was working but maybe I'm confused with lidar visualizer

@benemer
Copy link
Member Author

benemer commented Jul 2, 2024

Same thing there actually: https://github.com/PRBonn/lidar-visualizer/blob/3884578c3943c28b4bfba4ad8ca96a7fb3eca27a/src/lidar_visualizer/datasets/mcap.py#L51C1-L52C1

How to reproduce the error I faced: I had a mcap file with just one PointCloud2 message and did not specify the topic. Doing this, there was no warning that the topic should be passed (because it could extract it), but the resulting topic passed to the reader was empty.

So probably this did not fail before because we always passed the topic.

@benemer benemer merged commit 948bcbe into main Jul 3, 2024
17 checks passed
@benemer benemer deleted the benedikt/fix_mcap_topic_extraction branch July 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants