Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include headers #365

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Fix include headers #365

merged 12 commits into from
Jul 12, 2024

Conversation

saurabh1002
Copy link
Contributor

As a good student of @nachovizzo , I propose fixes to be consistent with the IWYU principle.

@saurabh1002
Copy link
Contributor Author

image

Eigen::AxisAngled is defined in Eigen/Geometry, which was getting included through Sophus/se3.hpp even when Preprocessing.cpp and Preprocessing.hpp made no use of the Sophus library.

nachovizzo
nachovizzo approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guptu

@tizianoGuadagnino tizianoGuadagnino merged commit 70c3e8d into PRBonn:main Jul 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tizianoGuadagnino tizianoGuadagnino tizianoGuadagnino approved these changes

@nachovizzo nachovizzo nachovizzo approved these changes

@benemer benemer Awaiting requested review from benemer benemer is a code owner

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabh1002 @nachovizzo @tizianoGuadagnino