refactor: remove superflouous facade

Refs #397

src/backend/models/preprints.ts

@@ -1,7 +1,7 @@
 import { EntityRepository, MikroORM, Repository } from '@mikro-orm/core';
 import { Preprint } from './entities';
 import { decodePreprintId } from '../../common/utils/ids';
-import { ChainError } from '../../common/errors';
+import ChainedError from 'typescript-chained-error';
 import { getLogger } from '../log.js';
 
 const log = getLogger('backend:model:preprints');
@@ -18,7 +18,7 @@ export class PreprintModel extends EntityRepository<Preprint> {
     try {
       return this.findOne({ uuid: value }, params);
     } catch (err) {
-      throw new ChainError(`'${value}' is not a valid UUID or Handle`);
+      throw new ChainedError(`'${value}' is not a valid UUID or Handle`);
     }
   }
 }

src/backend/models/users.ts

@@ -2,7 +2,7 @@ import { EntityRepository, MikroORM, Repository } from '@mikro-orm/core';
 import orcidUtils from 'orcid-utils';
 import { validate as uuidValidate } from 'uuid';
 import { User } from './entities';
-import { ChainError } from '../../common/errors';
+import ChainedError from 'typescript-chained-error';
 
 @Repository(User)
 export class UserModel extends EntityRepository<User> {
@@ -13,7 +13,7 @@ export class UserModel extends EntityRepository<User> {
       }
       return this.findOne({ uuid: value }, params);
     } catch (err) {
-      throw new ChainError('Failed to parse ORCID for user.', err);
+      throw new ChainedError('Failed to parse ORCID for user.', err);
     }
   }
 
@@ -24,7 +24,7 @@ export class UserModel extends EntityRepository<User> {
       }
       return this.findOne({ personas: { uuid: value } }, params);
     } catch (err) {
-      throw new ChainError(`Failed to find user for persona ${value}.`, err);
+      throw new ChainedError(`Failed to find user for persona ${value}.`, err);
     }
   }
 
@@ -36,7 +36,7 @@ export class UserModel extends EntityRepository<User> {
         params,
       );
     } catch (err) {
-      throw new ChainError(`Failed to find user for API appId ${app}.`, err);
+      throw new ChainedError(`Failed to find user for API appId ${app}.`, err);
     }
   }
 }

src/backend/utils/http-errors.ts

@@ -1,13 +1,12 @@
-import { ChainedErrorFactory } from 'typescript-chained-error';
-import { ChainError } from '../../common/errors';
+import ChainedError, { ChainedErrorFactory } from 'typescript-chained-error';
 
 interface HttpErrorProps {
   expose?: boolean;
   headers?: Record<string, string>;
   cleanStack?: boolean;
 }
 
-class HttpError extends ChainError {
+class HttpError extends ChainedError {
   readonly expose: boolean;
   readonly headers?: Record<string, string>;
   readonly status: number;
@@ -24,7 +23,7 @@ class HttpError extends ChainError {
     }
     const cleanStack =
       properties && properties.cleanStack ? properties.cleanStack : true;
-    super(`HTTP Error ${status}: ${message}`, cause, cleanStack);
+    super(`HTTP Error ${status}: ${message}`, cause, { cleanStack });
     this.status = status;
     this.expose =
       properties && properties.expose ? properties.expose : status < 500;

src/backend/utils/resolve.ts

@@ -5,7 +5,7 @@ import scrape from 'html-metadata';
 import { search as scholarSearch } from 'scholarly';
 import CrossRef from 'crossref';
 import { getOrcidPerson } from './orcid.js';
-import { ChainError } from '../../common/errors';
+import ChainedError from 'typescript-chained-error';
 import { getLogger } from '../log.js';
 
 const log = getLogger('backend:utils:resolve');
@@ -43,7 +43,7 @@ async function scrapeUrl(
       headers: { 'User-Agent': 'webscraper' },
     });
   } catch (err) {
-    throw new ChainError('Failed to scrape metadata:', err);
+    throw new ChainedError('Failed to scrape metadata:', err);
   }
 
   if (res) {
@@ -121,7 +121,7 @@ async function searchGoogleScholar(handle: string): Promise<PreprintMetadata> {
   try {
     res = await scholarSearch(handle);
   } catch (err) {
-    throw new ChainError('Failed to search Google Scholar:', err);
+    throw new ChainedError('Failed to search Google Scholar:', err);
   }
 
   if (res.length < 1) {
@@ -159,7 +159,7 @@ function searchCrossRef(handle: string): Promise<PreprintMetadata> {
   return new Promise((resolve, reject) => {
     CrossRef.work(handle, (err, res) => {
       if (err) {
-        reject(new ChainError('Failed to search CrossRef:', err));
+        reject(new ChainedError('Failed to search CrossRef:', err));
       } else {
         if (!res) {
           log.error(`Preprint ${handle} not found on CrossRef.`);

src/common/utils/ids.js

@@ -1,6 +1,6 @@
 import doiRegex from 'doi-regex';
 import identifiersArxiv from 'identifiers-arxiv';
-import { ChainError } from '../errors.ts';
+import ChainedError from 'typescript-chained-error';
 
 export function createPreprintId(
   value, // doi or arXiv (prefixed or not) or preprint
@@ -13,7 +13,7 @@ export function createPreprintId(
       id = value.doi || value.arXivId;
     }
     if (!id) {
-      throw new ChainError('Invalid identifier for create preprint id');
+      throw new ChainedError('Invalid identifier for create preprint id');
     }
   }
 
@@ -33,7 +33,7 @@ export function createPreprintId(
   }
 
   if (!vendor) {
-    throw new ChainError(
+    throw new ChainedError(
       'Invalid identifier for create preprint id (could not extract vendor)',
     );
   }
@@ -43,7 +43,7 @@ export function createPreprintId(
 
 export function decodePreprintId(value) {
   if (!value) {
-    throw new ChainError('You must provide a preprintId to decode');
+    throw new ChainedError('You must provide a preprintId to decode');
   }
 
   let scheme;
@@ -54,7 +54,7 @@ export function decodePreprintId(value) {
   }
 
   if (!scheme) {
-    throw new ChainError(
+    throw new ChainedError(
       'String is not an encoded preprint ID (could not extract scheme)',
     );
   }