Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code and configuration #397

Open
thewilkybarkid opened this issue Aug 11, 2021 · 0 comments
Open

Remove unused code and configuration #397

thewilkybarkid opened this issue Aug 11, 2021 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

There's an awful lot of code and configuration left over from previous versions of the site, and there are either never run or completely unused.

thewilkybarkid added a commit that referenced this issue Aug 11, 2021
The migration from the old site was run once, then turned off. This code has not been needed since and needs to be cleaned up.

Refs #391, #397
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
There's a whole directory full of 'archived' components. Since they are unused, they should be removed. (Since the code is under version control, that's a more suitable archive.)

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
This removes import statements that are either unused or commented out.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
Moves code from being classed as 'common' to where it's used.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
thewilkybarkid added a commit that referenced this issue Aug 16, 2021
Assuming this is a mistake; it's the only place where the backend code references the frontend and vice versa.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 17, 2021
thewilkybarkid added a commit that referenced this issue Aug 17, 2021
Following 3578f25 Sass is unused in the project.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 17, 2021
thewilkybarkid added a commit that referenced this issue Aug 18, 2021
Remove dependencies that aren't imported. In some cases, the dependency remains, it's just used by another dependency rather than that the app directly. In others, they're not used at all.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 18, 2021
thewilkybarkid added a commit that referenced this issue Aug 18, 2021
This change also moves the 2 remaining ones alongside the other assets.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
These settings are either unused or included by a preset.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
TypeScript files are processed using @parcel/transformer-typescript-tsc, not Babel.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
It turns out that the Babel configuration is not needed at all.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
Having them separate means that making a change doesn't bust the Docker cache.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
The package won't be published, so there's no need to include details there.

This change also removes the shebang from the backend entry point, which is redundant since the executable bit is not set.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 19, 2021
I'm not sure what these entries are for; they seem to duplicate the targets, but I can't determine what would use them.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 20, 2021
Only 2 of the scripts need to be built; this change removes those that don't.

Refs #397
thewilkybarkid added a commit that referenced this issue Aug 23, 2021
thewilkybarkid added a commit that referenced this issue Sep 7, 2021
It's unused and appears to do nothing anyhow.

Refs #397, #398
thewilkybarkid added a commit that referenced this issue Sep 10, 2021
I'm not sure why, but e0b6f9b broke npm. Executing an 'npm install' saw it restore Axios's dependencies.

Refs #397
thewilkybarkid added a commit that referenced this issue Sep 10, 2021
The app would have been originally generated with create-react-app or similar, which left over various things that are not needed. This change tidies up the entry point.

Refs #397
thewilkybarkid added a commit that referenced this issue Sep 17, 2021
thewilkybarkid added a commit that referenced this issue Sep 17, 2021
As IE is not supported, it's redundant to include a polyfill for it.

Refs #397
thewilkybarkid added a commit that referenced this issue Nov 26, 2021
thewilkybarkid added a commit that referenced this issue Dec 16, 2021
thewilkybarkid added a commit that referenced this issue Dec 16, 2021
Moves code from being classed as 'common' to the only place that uses it.

Refs #397, #430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant