Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOIs aren't treated as case insensitive #430

Closed
thewilkybarkid opened this issue Dec 13, 2021 · 0 comments
Closed

DOIs aren't treated as case insensitive #430

thewilkybarkid opened this issue Dec 13, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@thewilkybarkid
Copy link
Member

Searching for the DOI 10.31219/osf.io/f7txy returns details, 10.31219/osf.io/f7txY doesn't even though DOIs are case insensitive.

Worse, it's actually resolving the DOI data the second time and failing with a UniqueConstraintViolationException (on the handle being doi:10.31219/osf.io/f7txy). Crossref always returns a lowercase DOI; I don't know if any DOIs have been resolved from a webpage where it's not all lowercase (as that may result in multiple entries with different cases).

@thewilkybarkid thewilkybarkid added the bug Something isn't working label Dec 13, 2021
thewilkybarkid added a commit that referenced this issue Dec 14, 2021
This change adds test cases for resolving a preprint with a DOI that is already known, including a failing case where the DOI used is in a different case (as it should be case insensitive).

Refs #388, #430
thewilkybarkid added a commit that referenced this issue Dec 16, 2021
thewilkybarkid added a commit that referenced this issue Dec 16, 2021
Moves code from being classed as 'common' to the only place that uses it.

Refs #397, #430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant