Updates for C/S with Tax-Calc 3.0.0

[jdebacker]

This PR updates the cs-config files to work with the Tax-Calculator 3.0.0 and its use of ParamTools.

[codecov-commenter]

Codecov Report

Merging #637 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   84.06%   84.30%   +0.24%     
==========================================
  Files          47       47              
  Lines        6852     6959     +107     
==========================================
+ Hits         5760     5867     +107     
  Misses       1092     1092              

Impacted Files	Coverage Δ
ogusa/tests/test_get_micro_data.py	81.25% <ø> (+1.25%)	⬆️
ogusa/tests/test_tax.py	100.00% <0.00%> (ø)
ogusa/tests/test_firm.py	100.00% <0.00%> (ø)
ogusa/tests/test_utils.py	100.00% <0.00%> (ø)
ogusa/tests/test_fiscal.py	100.00% <0.00%> (ø)
ogusa/tests/test_income.py	100.00% <0.00%> (ø)
ogusa/tests/test_household.py	100.00% <0.00%> (ø)
ogusa/tests/test_aggregates.py	100.00% <0.00%> (ø)
ogusa/tests/test_output_plots.py	100.00% <0.00%> (ø)
ogusa/tests/test_parameter_plots.py	100.00% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad7dce...e5c25c9. Read the comment docs.

[rickecon]

@hdoupe made the following comments in merged PR #631 that was on a different issue.

Hey @MaxGhenis and @jdebacker, @Peter-Metz and have started going through the process of updating some of the cs-config code for Tax-Cruncher here: PSLmodels/Tax-Cruncher#38.

Tax-Cruncher doesn't have the CPS/PUF distinction so it's a little more straightforward. I'm planning to do the update to account for some parameters only being compatible with one of the files tomorrow or Wednesday.

[jdebacker]

@rickecon Yes, his updates as of about 10pm last night are included here. He made a few more changes today that I'll try to incorporate, but all tests are passing for cs_config currently.

[jdebacker]

@rickecon I've successfully run the full testing suite with the changes in this branch. It's ready for your review.

[hdoupe]

Sorry @jdebacker you need the function too. You're best bet is to just copy the file over in case I missed something else: https://github.com/PSLmodels/Tax-Cruncher/blob/master/cs-config/cs_config/inputs.py

Definitely looking forward to having a better set up for distributing these functions.

[rickecon]

@jdebacker. @hdoupe's last comment was:

Sorry @jdebacker you need the function too. You're best bet is to just copy the file over in case I missed something else: https://github.com/PSLmodels/Tax-Cruncher/blob/master/cs-config/cs_config/inputs.py

Definitely looking forward to having a better set up for distributing these functions.

It looks like this comment is satisfied/resolved by what we currently have in this PR in OG-USA/cs-config/cs_config/inputs.py. If that is correct, then this PR is ready to merge.

[jdebacker]

Ok, latest commit updates inputs.py to match that used in Tax-Cruncher.

Note that OG-USA only uses one function from inputs.py, convert_behavior_adjustment(), so all tests pass before the last two commits and continue to pass after.

[hdoupe]

Thanks for updating @jdebacker and review @rickecon . LGTM