Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for qualified business income and update to taxcalc 3.0 #38

Merged
merged 18 commits into from
Sep 1, 2020

Conversation

Peter-Metz
Copy link
Collaborator

@Peter-Metz Peter-Metz commented Aug 25, 2020

This PR adds five four parameters to Tax-Cruncher for calculation of the qualified business income deduction:

  • pbusinc: Primary filer's business income
  • sbusinc: Spouse's business income
  • businc: Business income (see comment)
  • sstb: Boolean for whether business income is from a professional services business
  • w2paid: W-2 wages paid by business
  • qualprop: Filer's share of qualified property

Also, this PR brings Tax-Cruncher up to speed with Tax-Calculator 3.0. Notably, this simplifies parameter processing within cs-config/ because of Tax-Calculator's adoption of Paramtools.

@hdoupe would you mind reviewing the changes related to CS?

@MattHJensen and @kpomerleau might be interested in the new QBID functionality

@Peter-Metz Peter-Metz changed the title Qbid Add parameters for qualified business income and update to taxcalc 3.0 Aug 25, 2020
@Peter-Metz Peter-Metz changed the title Add parameters for qualified business income and update to taxcalc 3.0 [WIP] Add parameters for qualified business income and update to taxcalc 3.0 Aug 25, 2020
@Peter-Metz
Copy link
Collaborator Author

In the latest commits, I've consolidated pbusinc and sbusinc into businc. Previously, pbusinc translated to e00900p and sbusinc translated to e00900s. Now, businc translates to e26270.

The reason for this change is twofold:

  1. Tax-Calculator uses e26270 in its test for QBID logic. I've adopted a very similar test for Tax-Cruncher that returns the same QBID amounts.
  2. There is an input field in Tax-Cruncher, but no Tax-Calculator parameter, for passive S-corp income. However, by asking for passive and activate S-corp income separately in Tax-Cruncher, we can calculate total S-corp income (e02000) to pass to Tax-Calculator and avoid double counting.

Update cs-config to use taxcalc.Policy directly
@Peter-Metz Peter-Metz changed the title [WIP] Add parameters for qualified business income and update to taxcalc 3.0 Add parameters for qualified business income and update to taxcalc 3.0 Sep 1, 2020
@Peter-Metz
Copy link
Collaborator Author

Thanks a lot for the assist @hdoupe! I'll merge this today if no one has objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants