-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters for qualified business income and update to taxcalc 3.0 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter-Metz
changed the title
Qbid
Add parameters for qualified business income and update to taxcalc 3.0
Aug 25, 2020
Peter-Metz
changed the title
Add parameters for qualified business income and update to taxcalc 3.0
[WIP] Add parameters for qualified business income and update to taxcalc 3.0
Aug 25, 2020
In the latest commits, I've consolidated The reason for this change is twofold:
|
hdoupe
reviewed
Aug 26, 2020
This was referenced Aug 31, 2020
Update cs-config to use taxcalc.Policy directly
Peter-Metz
changed the title
[WIP] Add parameters for qualified business income and update to taxcalc 3.0
Add parameters for qualified business income and update to taxcalc 3.0
Sep 1, 2020
Thanks a lot for the assist @hdoupe! I'll merge this today if no one has objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
fivefour parameters to Tax-Cruncher for calculation of the qualified business income deduction:pbusinc
: Primary filer's business incomesbusinc
: Spouse's business incomebusinc
: Business income (see comment)sstb
: Boolean for whether business income is from a professional services businessw2paid
: W-2 wages paid by businessqualprop
: Filer's share of qualified propertyAlso, this PR brings Tax-Cruncher up to speed with Tax-Calculator 3.0. Notably, this simplifies parameter processing within
cs-config/
because of Tax-Calculator's adoption of Paramtools.@hdoupe would you mind reviewing the changes related to CS?
@MattHJensen and @kpomerleau might be interested in the new QBID functionality