Update cs-config to use taxcalc.Policy directly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdoupe
commented
Aug 31, 2020
|
|
||
| policy_params.set_state( | ||
| year=metaparams.year.tolist()) | ||
|
|
||
| filtered_pol_params = OrderedDict() | ||
| policy_params._schema["operators"].update( | ||
| {"label_to_extend": None, "uses_extend_func": False, "array_first": False} | ||
| ) |
There was a problem hiding this comment.
@Peter-Metz I'll go back and fix this once PSLmodels/ParamTools#117 is resolved.
|
Thanks a bunch @hdoupe! Is this good to merge or should we wait for PSLmodels/ParamTools#117? |
|
@Peter-Metz This is good to go! I have a PR open to resolve the operators issue, but I'm still doing some testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Peter-Metz This should resolve the issues from PSLmodels#38 (comment). I opened PSLmodels/ParamTools#117 to better address the issue that this not-so-nice-looking snippet is dealing with: