Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Image Documents #6

Merged
merged 19 commits into from
Jan 9, 2019
Merged

Add support for Image Documents #6

merged 19 commits into from
Jan 9, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Dec 13, 2018 •
edited by simoarpe
Loading

⚠️Both the Android and iOS parts need to be implemented before merging ⚠️

This pull request adds support for Image Documents, adding the ability to annotate image files (png and jpeg).

recording

  • Implement the Android part.
  • Implement the iOS part.

@radazzouz radazzouz added enhancement New feature or request Android iOS labels Dec 13, 2018
simoarpe
simoarpe approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS part looks good 👍

@simoarpe
Add back abi workaround as the bug is showing up again
20a07a5 
This reverts commit 42aa9b8.
More info about the issue here flutter/flutter#15733 and herehttps://github.com/flutter/flutter/issues/18494

Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Open image document when "png", "jpg" or "jpeg"
392d2da 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Upgrade to PSPDFKit for Android 5.1.1
2356832 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Migrate to AndroidX
8f2c8b6 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Enable multiDex
ce6ff2f 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Example project version bump
0b4dbc9 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
PSPDFKit flutter plugin version bump
59dbfaf 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe simoarpe added the READY TO REVIEW Pull request ready to review label Jan 3, 2019
@simoarpe simoarpe changed the title [WIP] Add support for Image Documents Add support for Image Documents Jan 3, 2019
@simoarpe simoarpe removed the READY TO REVIEW Pull request ready to review label Jan 4, 2019
@simoarpe simoarpe added the READY TO REVIEW Pull request ready to review label Jan 8, 2019
@simoarpe
Remove abiFilters
aef0b12 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@radazzouz
Copy link
Contributor Author

I was able to successfully run both the iOS and Android implementation. 👍

@simoarpe simoarpe merged commit c3f570c into master Jan 9, 2019
@simoarpe simoarpe deleted the image-documents branch January 9, 2019 11:57
radazzouz pushed a commit that referenced this pull request Jan 10, 2020
Rename image to fix the exception in the Image Document example
29ad4b3 
Having spaces in the assert name caused the following exception on both iOS and Android:

```
[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Unable to load asset: PDFs/PSPDFKit Image Example.jpg
#0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:221:7)
<asynchronous suspension>
#1      _MyAppState.extractAsset (package:pspdfkit_example/main.dart:53:65)
#2      _MyAppState.showImage (package:pspdfkit_example/main.dart:75:41)
#3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#4      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
#5      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
#6      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:236:7)
#7      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156:27)
#8      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:222:20)
#9      GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:198:22)
#10     GestureBinding<…>
[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Unable to load asset: PDFs/PSPDFKit Image Example.jpg
#0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:221:7)
<asynchronous suspension>
#1      _MyAppState.extractAsset (package:pspdfkit_example/main.dart:53:65)
#2      _MyAppState.showImage (package:pspdfkit_example/main.dart:75:41)
#3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#4      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
#5      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
#6      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:236:7)
#7      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156:27)
#8      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:222:20)
#9      GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:198:22)
#10     GestureBinding<…>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoarpe simoarpe simoarpe approved these changes

Assignees

@simoarpe simoarpe

@radazzouz radazzouz

Labels
Android enhancement New feature or request iOS READY TO REVIEW Pull request ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @simoarpe