Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend support for styling and configuration options #7

Merged
merged 21 commits into from
Mar 25, 2019
Merged

Extend support for styling and configuration options #7

merged 21 commits into from
Mar 25, 2019

Conversation

simoarpe
Copy link
Contributor

@simoarpe simoarpe commented Jan 16, 2019 •
edited by radazzouz
Loading

This PR extends support for styling via Flutter methods and implement some configuration options to stay aligned with the customizations offered in our React Native wrapper repository.

Example app layout undergoes a major refactoring for both Android and iOS.

Dart language adopts Effective Dart guidelines

Project files include copyright header

Android

screenshot_20190116-145838

iOS

screenshot 2019-01-16 14 58 11

Acceptance Criteria

@simoarpe simoarpe self-assigned this Jan 16, 2019
simoarpe added 11 commits March 1, 2019 16:53
@simoarpe
Remove unused meta data
b39f5c0 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Custom dark theme example resources
68d100d 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Configuration adapter implementation
93e7136 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Add configuration option Dart strings
75a1327 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Better analysis options
8bc0e73 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Add iOS layout and minor refactoring
faeed18 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Example version bump
f28b3c2 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Flutter project version bump
1fc8532 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Unify configuration options
7e8b390 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Apply Effective Dart style
e19d1a0 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Add copyright header to project files
749c982 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe simoarpe force-pushed the simone/styling-configuration-support branch from e1f6558 to 749c982 Compare March 1, 2019 15:54
@davidschreiber davidschreiber added READY TO REVIEW Pull request ready to review Android labels Mar 4, 2019
@radazzouz radazzouz self-assigned this Mar 10, 2019
davidschreiber
davidschreiber approved these changes Mar 13, 2019
View reviewed changes
analysis_options.yaml Outdated Show resolved Hide resolved
analysis_options.yaml Show resolved Hide resolved
android/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
android/src/main/java/com/pspdfkit/flutter/pspdfkit/ConfigurationAdapter.java Outdated Show resolved Hide resolved
android/src/main/java/com/pspdfkit/flutter/pspdfkit/ConfigurationAdapter.java Outdated Show resolved Hide resolved
example/android/app/src/main/res/values/dark_theme.xml Outdated Show resolved Hide resolved
example/android/app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
example/android/app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
example/lib/main.dart Show resolved Hide resolved
lib/configuration_options.dart Outdated Show resolved Hide resolved
simoarpe added 2 commits March 18, 2019 18:42
@simoarpe
Review cleanup
d2b498e 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Update launch_background.xml
8a2579f
simoarpe added 3 commits March 19, 2019 15:57
@simoarpe
Address review remarks
05c3bba 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe
Merge branch 'simone/styling-configuration-support' of https://github…
1303e2e 
….com/PSPDFKit/pspdfkit-flutter into simone/styling-configuration-support
@simoarpe
Refactor ConfigurationAdapter
6a63303 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe simoarpe merged commit bcdfea8 into master Mar 25, 2019
@simoarpe simoarpe deleted the simone/styling-configuration-support branch March 25, 2019 10:42
@radazzouz
Copy link
Contributor

Here's the iOS implementation PR: #10

radazzouz pushed a commit that referenced this pull request Jan 10, 2020
Rename image to fix the exception in the Image Document example
29ad4b3 
Having spaces in the assert name caused the following exception on both iOS and Android:

```
[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Unable to load asset: PDFs/PSPDFKit Image Example.jpg
#0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:221:7)
<asynchronous suspension>
#1      _MyAppState.extractAsset (package:pspdfkit_example/main.dart:53:65)
#2      _MyAppState.showImage (package:pspdfkit_example/main.dart:75:41)
#3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#4      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
#5      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
#6      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:236:7)
#7      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156:27)
#8      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:222:20)
#9      GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:198:22)
#10     GestureBinding<…>
[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Unable to load asset: PDFs/PSPDFKit Image Example.jpg
#0      PlatformAssetBundle.load (package:flutter/src/services/asset_bundle.dart:221:7)
<asynchronous suspension>
#1      _MyAppState.extractAsset (package:pspdfkit_example/main.dart:53:65)
#2      _MyAppState.showImage (package:pspdfkit_example/main.dart:75:41)
#3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#4      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
#5      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
#6      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:236:7)
#7      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156:27)
#8      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:222:20)
#9      GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:198:22)
#10     GestureBinding<…>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irgendeinich irgendeinich irgendeinich approved these changes

@davidschreiber davidschreiber davidschreiber approved these changes

Assignees

@simoarpe simoarpe

@radazzouz radazzouz

Labels
Android READY TO REVIEW Pull request ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simoarpe @radazzouz @davidschreiber @irgendeinich