Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting started instructions for React Native 0.63.2 #376

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Sep 8, 2020

Details

This PR updates the getting started instructions to work with React Native 0.63.2.

It also updates the CocoaPods integration to use the fat frameworks instead of the XCFrameworks, because of the known CocoaPods issues with XCFrameworks (CocoaPods/CocoaPods#9681 and CocoaPods/CocoaPods#9990)

Acceptance Criteria

  • Create a new React Native project and integrate PSPDFKit using the new instructions.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested with integrating PSPDFKit into a new project.

@radazzouz radazzouz merged commit 354738e into master Sep 8, 2020
@radazzouz radazzouz deleted the rad/update-for-rn-0.63.2 branch September 8, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants