Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 10 for iOS and Xcode 12 #378

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Update for PSPDFKit 10 for iOS and Xcode 12 #378

merged 4 commits into from
Sep 22, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Sep 15, 2020 •
edited
Loading

⚠️ Only merge after PSPDFKit 10 for iOS is released ⚠️

Details

This PR updates the plugin for PSPDFKit 10 for iOS and Xcode 12.

This PR also re-adds support for XCFrameworks which was removed in #376.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@steipete steipete changed the title Update for PSPDFKit 9.5 for iOS and Xcode 12 Update for PSPDFKit 10 for iOS and Xcode 12 Sep 16, 2020
steviki
steviki approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radazzouz radazzouz requested a review from steviki September 16, 2020 13:36
steviki
steviki approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radazzouz radazzouz self-assigned this Sep 16, 2020
@radazzouz radazzouz merged commit 1e82ac0 into master Sep 22, 2020
@radazzouz radazzouz deleted the rad/update-for-v10-for-ios branch September 22, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steviki