Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recon examples of Cartesian Siemens scans #233

Closed
wants to merge 8 commits into from
Closed

Conversation

hdillinger
Copy link
Collaborator

@hdillinger hdillinger commented Mar 22, 2024

Fixes #518

Added file to illustrate the use of matplotlib's imshow for non-isotropic pixel/voxel data.

The output:
grafik

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms/csm
   inati.py24196%44
   walsh.py16194%34
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%15, 48–49, 76
src/mrpro/algorithms/optimizers
   adam.py20195%69
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%51–71, 85
   IterativeSENSEReconstruction.py422345%77–78, 88–98, 113–124, 138–149
   Reconstruction.py512453%41, 53–55, 79–86, 103–114
src/mrpro/data
   AcqInfo.py128298%174, 214
   CsmData.py28389%14, 81–83
   DcfData.py44882%17, 65, 77–82
   IData.py67987%119, 125, 129, 159–167
   IHeader.py75791%75, 109, 127–131
   KHeader.py1641790%24, 126–130, 157, 207, 218, 225–226, 229, 236, 275–286
   KNoise.py311552%39–52, 56–61
   KTrajectory.py69593%178–182
   MoveDataMixin.py1261489%14, 109, 125, 139–141, 202, 265, 279, 358, 378–379, 396–397
   QData.py39782%42, 65–73
   Rotation.py4472295%96, 277, 362, 364, 391, 446, 451, 454, 469, 486, 491, 634, 639, 642, 658, 662, 736, 738, 746–747, 987, 1069
   SpatialDimension.py46296%64, 103
   TrajectoryDescription.py14193%23
   acq_filters.py10190%47
src/mrpro/data/_kdata
   KData.py1051685%108–109, 118, 126, 180–181, 216, 221–222, 241–252
   KDataRemoveOsMixin.py29293%44, 46
   KDataSelectMixin.py20290%47, 63
   KDataSplitMixin.py48394%50, 80, 89
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%23, 45
   KTrajectoryIsmrmrd.py13285%41, 50
   KTrajectoryPulseq.py29197%54
src/mrpro/operators
   CartesianSamplingOp.py50982%49–50, 55–56, 61–62, 88, 91, 114
   ConstraintsOp.py60297%46, 48
   EndomorphOperator.py64297%225, 231
   FiniteDifferenceOp.py27293%40, 105
   FourierOp.py77199%131
   Functional.py43295%108, 110
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py1601292%54, 90, 189, 217, 258, 267, 275, 284, 292, 303, 401, 406
   MultiIdentityOp.py13285%44, 49
   Operator.py76297%24, 67
   SliceProjectionOp.py173895%44, 61, 63, 69, 206, 227, 260, 300
   WaveletOp.py120596%152, 170, 205, 210, 233
   ZeroPadOp.py16194%30
src/mrpro/utils
   filters.py62297%44, 49
   modify_acq_info.py17194%12
   slice_profiles.py46687%20, 36, 113–116, 149
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py11918%20–29
   typing.py12742%6–15
   zero_pad_or_crop.py31681%26, 30, 54, 57, 60, 63
TOTAL397530292% 

Tests Skipped Failures Errors Time
1547 0 💤 0 ❌ 0 🔥 1m 26s ⏱️

Copy link
Member

@fzimmermann89 fzimmermann89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is helpful to have in mrpro in this form:
If we want to have an example that shows how properly plot to somebody how does not know matplotlib in mrpro (not sure if we do),
I would instead provide the simplest example without subplots and loops.
And separate creating the random data, recon_matrix (not encoding AFAIK) with the proper type etc from plotting it..
The main point of this example gets somehow lost in the code..

Or is this just an example to showcase something during the hackathon and not meant to end up in main

Edit: OK.. The latter. :D

@ckolbPTB ckolbPTB changed the title imshow example Recon examples of Cartesian Siemens scans May 28, 2024
@schuenke schuenke mentioned this pull request May 28, 2024
@fzimmermann89
Copy link
Member

related: #518

@ckolbPTB
Copy link
Collaborator

ckolbPTB commented Jan 6, 2025

Superseded by #562

@ckolbPTB ckolbPTB closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cartesian Reconstruction example
4 participants