Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude data outside of encoding_matrix #234

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Exclude data outside of encoding_matrix #234

merged 10 commits into from
Nov 12, 2024

Conversation

ckolbPTB
Copy link
Collaborator

closes #217

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms/csm
   inati.py24196%44
   walsh.py16194%34
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%15, 48–49, 76
src/mrpro/algorithms/optimizers
   adam.py20195%69
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%51–71, 85
   IterativeSENSEReconstruction.py13192%76
   Reconstruction.py502256%42, 54–56, 80–87, 104–113
   RegularizedIterativeSENSEReconstruction.py411759%96–100, 114–139
src/mrpro/data
   AcqInfo.py128398%26, 169, 207
   CsmData.py29390%15, 82–84
   DcfData.py45882%18, 66, 78–83
   IData.py67987%119, 125, 129, 159–167
   IHeader.py75791%75, 109, 127–131
   KHeader.py1531789%25, 119–123, 150, 199, 210, 217–218, 221, 228, 260–271
   KNoise.py311552%39–52, 56–61
   KTrajectory.py69593%178–182
   MoveDataMixin.py1371887%15, 113, 129, 143–145, 207, 305–307, 320, 399, 419–420, 422, 437–438, 440
   QData.py39782%42, 65–73
   Rotation.py6743595%100, 198, 335, 433, 477, 495, 581, 583, 592, 626, 628, 691, 768, 773, 776, 791, 808, 813, 889, 1077, 1082, 1085, 1109, 1113, 1240, 1242, 1250–1251, 1315, 1397, 1690, 1846, 1881, 1885, 1996
   SpatialDimension.py2302191%33, 103, 128, 135, 141, 261–263, 276–278, 312, 330, 343, 356, 369, 382, 391–392, 407, 416
   acq_filters.py12192%47
src/mrpro/data/_kdata
   KData.py1121884%108–109, 124, 131, 141, 149, 203–204, 242, 247–248, 267–278
   KDataRemoveOsMixin.py29293%44, 46
   KDataSelectMixin.py19289%48, 63
   KDataSplitMixin.py48394%53, 84, 93
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%23, 45
   KTrajectoryIsmrmrd.py13285%41, 50
   KTrajectoryPulseq.py29197%54
src/mrpro/operators
   CartesianSamplingOp.py72297%118, 157
   ConstraintsOp.py60297%46, 48
   EndomorphOperator.py65297%228, 234
   FiniteDifferenceOp.py27293%40, 105
   Functional.py71593%20–22, 117, 119
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py1711293%55, 91, 190, 220, 261, 270, 278, 287, 295, 320, 418, 423
   LinearOperatorMatrix.py1581690%82, 119, 152, 161, 166, 175–178, 191–194, 203, 215, 304, 331, 359
   MultiIdentityOp.py13285%43, 48
   Operator.py78297%25, 74
   ProximableFunctionalSeparableSum.py39392%50, 103, 110
   SliceProjectionOp.py173895%44, 61, 63, 69, 206, 227, 260, 300
   WaveletOp.py120596%152, 170, 205, 210, 233
   ZeroPadOp.py16194%30
src/mrpro/utils
   filters.py62297%44, 49
   slice_profiles.py46687%20, 36, 113–116, 149
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py11918%20–29
   typing.py181139%8–23
   zero_pad_or_crop.py31681%26, 30, 54, 57, 60, 63
TOTAL475435093% 

Tests Skipped Failures Errors Time
1971 0 💤 0 ❌ 0 🔥 1m 55s ⏱️

@ckolbPTB
Copy link
Collaborator Author

any ideas of what to do now with the exclude info are very welcome

@ckolbPTB ckolbPTB marked this pull request as ready for review June 5, 2024 09:23
Copy link
Contributor

github-actions bot commented Nov 10, 2024

📚 Documentation

📁 Download as zip
🔍 View online

@fzimmermann89
Copy link
Member

fzimmermann89 commented Nov 11, 2024

  • rebased to main.
  • made test more difficult: two oversampled axes and other dimension (which failed)
  • change the index creation to use non-zero
  • fix for other dimension, unbreaks more difficult test. uses unsqueeze_left
  • tiny performance thing: order of adding broadcasted tensors to figure out the inside_mask
  • removed the bool marking telling if inside_matrix indices exist, and instead make it the indices optional/None.
  • changed some comments (minor)

@ckolbPTB did I mess anything up?

I also think there might be a nicer way to do this, but this works for now, lets see if it ever actually becomes a performance bottleneck.

@ckolbPTB
Copy link
Collaborator Author

verified on real data

@fzimmermann89
Copy link
Member

Thank you for checking on real data! I will merge?

@fzimmermann89 fzimmermann89 enabled auto-merge (squash) November 12, 2024 12:05
@fzimmermann89 fzimmermann89 merged commit 202d395 into main Nov 12, 2024
20 checks passed
@fzimmermann89 fzimmermann89 deleted the fix_217 branch November 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch encoding limits - encoding matrix
2 participants