-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude data outside of encoding_matrix #234
Merged
Merged
+115
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any ideas of what to do now with the exclude info are very welcome |
ckolbPTB
commented
Jun 5, 2024
fzimmermann89
force-pushed
the
fix_217
branch
from
November 10, 2024 18:49
22657ae
to
49d6968
Compare
fzimmermann89
force-pushed
the
fix_217
branch
from
November 10, 2024 18:56
49d6968
to
a54126f
Compare
📚 Documentation |
@ckolbPTB did I mess anything up? I also think there might be a nicer way to do this, but this works for now, lets see if it ever actually becomes a performance bottleneck. |
fzimmermann89
approved these changes
Nov 11, 2024
verified on real data |
Thank you for checking on real data! I will merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217