-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add human readable ids to test #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure about the signal model names... |
Coverage Report
|
📚 Documentation |
fzimmermann89
force-pushed
the
ids
branch
3 times, most recently
from
October 27, 2024 15:35
bd01971
to
0256286
Compare
@schuenke any idea why here are two coverage comments? |
fzimmermann89
changed the title
Make some of our tests parameterizations a bit easier to understand
Add human readable ids to test
Oct 27, 2024
fzimmermann89
requested review from
schuenke,
koflera and
ckolbPTB
and removed request for
koflera
October 27, 2024 15:41
hmmm not sure, no. In the checks it says that a previous comment was found and updated for all 3 pytest runs (py 3.10, 3.11 and 3.12). Maybe a bug due to the force-push while a previos test was still running? |
ckolbPTB
reviewed
Nov 2, 2024
Merged
ckolbPTB
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed most of the really confusing parameterized names.
There are instances where I in the past used a string in the parameterization just to have a readable test name. In theory, this could also be changed now that I learned about the ids parameter..
If anybody notices any other tests where the parameterizations can be named better, feel free to contribute here.
also, rename 'uf' and 'nuf' to uniform and non-uniform etc.