fix test installation from TestPyPi workflow

[schuenke]

I added a retry loop in the installation from TestPyPi step to avoid the workflow to fail because the deployed package from the previous step is not yet fully available for download / installation.

As far as I know, there is no status / availability check available.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/mrpro/algorithms/csm
inati.py	24	1	96%	44
walsh.py	16	1	94%	34
src/mrpro/algorithms/dcf
dcf_voronoi.py	53	4	92%	15, 48–49, 76
src/mrpro/algorithms/optimizers
adam.py	20	1	95%	69
src/mrpro/algorithms/reconstruction
DirectReconstruction.py	28	16	43%	51–71, 85
IterativeSENSEReconstruction.py	13	1	92%	76
Reconstruction.py	50	22	56%	42, 54–56, 80–87, 104–113
RegularizedIterativeSENSEReconstruction.py	41	17	59%	96–100, 114–139
src/mrpro/data
AcqInfo.py	128	2	98%	174, 212
CsmData.py	29	3	90%	15, 82–84
DcfData.py	45	8	82%	18, 66, 78–83
IData.py	67	9	87%	119, 125, 129, 159–167
IHeader.py	75	7	91%	75, 109, 127–131
KHeader.py	165	17	90%	25, 127–131, 158, 210, 221, 228–229, 232, 239, 278–289
KNoise.py	31	15	52%	39–52, 56–61
KTrajectory.py	69	5	93%	178–182
MoveDataMixin.py	137	18	87%	15, 113, 129, 143–145, 207, 305–307, 320, 399, 419–420, 422, 437–438, 440
QData.py	39	7	82%	42, 65–73
Rotation.py	674	36	95%	100, 198, 335, 433, 477, 495, 581, 583, 592, 626, 628, 691, 768, 773, 776, 791, 808, 813, 889, 1077, 1082, 1085, 1109, 1113, 1240, 1242, 1250–1251, 1315, 1397, 1608, 1690, 1846, 1881, 1885, 1996
SpatialDimension.py	230	21	91%	33, 103, 128, 135, 141, 261–263, 276–278, 312, 330, 343, 356, 369, 382, 391–392, 407, 416
TrajectoryDescription.py	14	1	93%	23
acq_filters.py	10	1	90%	47
src/mrpro/data/_kdata
KData.py	105	16	85%	108–109, 118, 126, 180–181, 216, 221–222, 241–252
KDataRemoveOsMixin.py	29	2	93%	44, 46
KDataSelectMixin.py	21	2	90%	48, 64
KDataSplitMixin.py	49	3	94%	51, 81, 90
src/mrpro/data/traj_calculators
KTrajectoryCalculator.py	25	2	92%	23, 45
KTrajectoryIsmrmrd.py	13	2	85%	41, 50
KTrajectoryPulseq.py	29	1	97%	54
src/mrpro/operators
CartesianSamplingOp.py	50	4	92%	49–50, 90, 116
ConstraintsOp.py	60	2	97%	46, 48
EndomorphOperator.py	65	2	97%	228, 234
FiniteDifferenceOp.py	27	2	93%	40, 105
FourierOp.py	77	1	99%	131
Functional.py	71	5	93%	20–22, 117, 119
GridSamplingOp.py	136	9	93%	72–73, 82–83, 90–91, 94, 96, 98
LinearOperator.py	171	12	93%	55, 91, 190, 220, 261, 270, 278, 287, 295, 320, 418, 423
LinearOperatorMatrix.py	158	16	90%	82, 119, 152, 161, 166, 175–178, 191–194, 203, 215, 304, 331, 359
MultiIdentityOp.py	13	2	85%	43, 48
Operator.py	78	2	97%	25, 74
ProximableFunctionalSeparableSum.py	39	3	92%	50, 103, 110
SliceProjectionOp.py	173	8	95%	44, 61, 63, 69, 206, 227, 260, 300
WaveletOp.py	120	5	96%	152, 170, 205, 210, 233
ZeroPadOp.py	16	1	94%	30
src/mrpro/utils
filters.py	62	2	97%	44, 49
modify_acq_info.py	17	1	94%	12
slice_profiles.py	46	6	87%	20, 36, 113–116, 149
sliding_window.py	34	1	97%	34
split_idx.py	10	2	80%	43, 47
summarize_tensorvalues.py	11	9	18%	20–29
typing.py	18	11	39%	8–23
zero_pad_or_crop.py	31	6	81%	26, 30, 54, 57, 60, 63
TOTAL	4738	353	93%

Tests	Skipped	Failures	Errors	Time
1953	0 💤	0 ❌	0 🔥	1m 40s ⏱️

[github-actions]

📚 Documentation

📁 Download as zip
🔍 View online

[lrlunin]

In my opinion (which can be potentially wrong) I would rather put this block to the Publish to TestPyPI step. This way we would make the upload of the package "smart", in sense that upload will ensure and guarantee that the version is available. It would make more sense in case if цу would like to perform more things related to the package. Then we can just set a trigger to this step ready instead of monitoring the state of the package in each upcoming sub-routine.

[schuenke]

In my opinion (which can be potentially wrong) I would rather put this block to the Publish to TestPyPI step.

I think I would at least make it another step, no? Or am I missing that pypa/gh-action-pypi-publish already has this feature implemented?

This way we would make the upload of the package "smart", in sense that upload will ensure and guarantee that the version is available.

Assuming pypa/gh-action-pypi-publish doesn't support this: what would be your idea to verify the availability? Directly checking in the projects metadata (https://test.pypi.org/pypi/mrpro/json) if the $VERSION$SUFFIX is available?

It would make more sense in case if цу would like to perform more things related to the package. Then we can just set a trigger to this step ready instead of monitoring the state of the package in each upcoming sub-routine.

Currently, I don't think we will do more checks on the TestPyPi package, but ofc you never know 😄

[lrlunin]

I think I would at least make it another step, no? Or am I missing that pypa/gh-action-pypi-publish already has this feature implemented?

Oups, I mean an additonal step in the same group. You're correct.

Assuming pypa/gh-action-pypi-publish doesn't support this: what would be your idea to verify the availability? Directly checking in the projects metadata (https://test.pypi.org/pypi/mrpro/json) if the $VERSION$SUFFIX is available?

I briefly looked at the existing parameters and didn't find those. I'll raise an issue and ask if the the action would like to cover this thing. It sounds very reasonable for me.