Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve mavlink set_attitude_target handling #1983

Closed
wants to merge 1 commit into from
Closed

improve mavlink set_attitude_target handling #1983

wants to merge 1 commit into from

Conversation

thomasgubler
Copy link
Contributor

port #1920 to mavlink_receiver
fixes #1921

untested

@AndreasAntener please review

@LorenzMeier
Copy link
Member

I did a forced update to re-trigger the CI tools. They should be behaving now again.

@LorenzMeier
Copy link
Member

@AndreasAntener Good to go?

@AndreasAntener
Copy link
Member

Looks ok. Isn't there someone who does attitude control? ;)

@LorenzMeier LorenzMeier mentioned this pull request Apr 9, 2015
Closed
4 tasks
This was referenced Apr 18, 2015
Closed
Closed
Closed
@thomasgubler thomasgubler mentioned this pull request May 1, 2015
Closed
@AndreasAntener
Copy link
Member

@dvorak0 did a test with this.

I've pulled #1983 locally. During my test(set attitude and thrust through mavros) it works well. Maybe it's time to merge it.

@LorenzMeier
Copy link
Member

@thomasgubler Could you rebase and apply this to master? Thanks!

@LorenzMeier
Copy link
Member

Applied, closing, thanks!

@LorenzMeier LorenzMeier closed this May 7, 2015
@LorenzMeier LorenzMeier deleted the mavlinkfixsetattitudetarget branch May 7, 2015 15:14
PX4BuildBot added a commit that referenced this pull request May 3, 2023
@PX4BuildBot
Update submodule mavlink to latest Wed May 3 12:39:31 UTC 2023
f53a583 
    - mavlink in PX4/Firmware (9b9117a): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@fdef5cc
    - Changes: mavlink/mavlink@3ee5382...fdef5cc

    fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 5, 2023
@PX4BuildBot
Update submodule mavlink to latest Fri May 5 00:39:34 UTC 2023
1d87f16 
    - mavlink in PX4/Firmware (1a734c9): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 6, 2023
@PX4BuildBot
Update submodule mavlink to latest Sat May 6 12:39:10 UTC 2023
f4ebb81 
    - mavlink in PX4/Firmware (ec01b38): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 7, 2023
@PX4BuildBot
Update submodule mavlink to latest Sun May 7 12:38:33 UTC 2023
cf814cc 
    - mavlink in PX4/Firmware (c4afacb): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 8, 2023
@PX4BuildBot
Update submodule mavlink to latest Mon May 8 00:38:39 UTC 2023
ed43f07 
    - mavlink in PX4/Firmware (b423eba): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
@dagar dagar mentioned this pull request May 8, 2023
Merged
PX4BuildBot added a commit that referenced this pull request May 8, 2023
@PX4BuildBot
Update submodule mavlink to latest Mon May 8 12:39:24 UTC 2023
d76b813 
    - mavlink in PX4/Firmware (7e6d3d1): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 9, 2023
@PX4BuildBot
Update submodule mavlink to latest Tue May 9 00:39:19 UTC 2023
f18911a 
    - mavlink in PX4/Firmware (b2ce4ed): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 10, 2023
@PX4BuildBot
Update submodule mavlink to latest Wed May 10 00:39:23 UTC 2023
777047d 
    - mavlink in PX4/Firmware (ced5be5): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@ce00667
    - Changes: mavlink/mavlink@3ee5382...ce00667

    ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 10, 2023
@PX4BuildBot
Update submodule mavlink to latest Wed May 10 13:13:36 UTC 2023
ad84b6b 
    - mavlink in PX4/Firmware (7eb9fe8): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@e9bf6a6
    - Changes: mavlink/mavlink@3ee5382...e9bf6a6

    e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 11, 2023
@PX4BuildBot
Update submodule mavlink to latest Thu May 11 12:39:15 UTC 2023
100bb76 
    - mavlink in PX4/Firmware (153a90e): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 17, 2023
@PX4BuildBot
Update submodule mavlink to latest Wed May 17 00:39:23 UTC 2023
afb52b1 
    - mavlink in PX4/Firmware (6f9be9f): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 18, 2023
@PX4BuildBot
Update submodule mavlink to latest Thu May 18 00:39:18 UTC 2023
dbdb217 
    - mavlink in PX4/Firmware (b78e6e8): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 18, 2023
@PX4BuildBot
Update submodule mavlink to latest Thu May 18 12:38:42 UTC 2023
c63f5b9 
    - mavlink in PX4/Firmware (1608d31): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
PX4BuildBot added a commit that referenced this pull request May 19, 2023
@PX4BuildBot
Update submodule mavlink to latest Fri May 19 12:38:47 UTC 2023
272a749 
    - mavlink in PX4/Firmware (0ff9816): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
dagar pushed a commit that referenced this pull request May 19, 2023
@PX4BuildBot @dagar
Update submodule mavlink to latest Fri May 19 12:38:47 UTC 2023
7410590 
    - mavlink in PX4/Firmware (0ff9816): mavlink/mavlink@3ee5382
    - mavlink current upstream: mavlink/mavlink@18955a0
    - Changes: mavlink/mavlink@3ee5382...18955a0

    18955a04 2023-05-11 Nick Exton - common.xml: Add MAV_RESULT_COMMAND_LONG_ONLY and MAV_RESULT_COMMAND_INT_ONLY to MAV_RESULT (#1982)
b92321ba 2023-03-30 Hamish Willee - Update message_definitions/v1.0/common.xml
58ff70f4 2023-03-30 Hamish Willee - COMMAND_ACK progress/result_param2 clarification
31b4aebb 2023-05-11 Julian Oes - cmake: locally install pip dependencies (#1984)
e9bf6a61 2023-05-10 Hamish Willee - Gimbal manager messages - remove WIP tagging (#1980)
0416967f 2023-05-10 Beat Küng - development: changes to standard flight modes (#1915)
ce00667f 2023-05-04 Jonas Vautherin - New cmakelists (#1977)
fdef5cc0 2023-05-03 Nick Exton - common.xml: Prefer COMMAND_INT when command includes altitude field (#1983)
89676d1d 2023-05-03 Nick Exton - common.xml: Add ZOOM_TYPE_HORIZONTAL_FOV to CAMERA_ZOOM_TYPE enum (#1979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mavlink receiver: fix attitude sp logic
3 participants
@thomasgubler @LorenzMeier @AndreasAntener