Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: Synchronize FMUv5x/v6x board configs #23977

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

boards: Synchronize FMUv5x/v6x board configs #23977

wants to merge 1 commit into from
+2 −0

Conversation

niklaut
Copy link
Contributor

@niklaut niklaut commented Nov 19, 2024

Solved Problem

Keeping the FMUv5x and FMUv6x board configs more in sync.

Remaining diff.
https://www.diffchecker.com/h3vekNYV/

Changelog Entry

For release notes:

Synchronize FMUv5x and FMUv6x board config

Test coverage

tbd

Context

Related links, screenshot before/after, video

@niklaut niklaut requested a review from sfuhrer November 19, 2024 18:03
sfuhrer
sfuhrer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care @niklaut!
If I see it correctly now the v6x flash is overflowing by 12kB, can that call coming from CONFIG_COMMON_RC? 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfuhrer sfuhrer sfuhrer approved these changes

@dagar dagar dagar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklaut @dagar @sfuhrer