【code format check upgrade】 step1：cpplint (#43175)

* test=document_fix * cpplint set version 1.6.0;test=document_fix
PaddlePaddle · Jun 6, 2022 · 19b4ff4 · 19b4ff4
1 parent e860538
commit 19b4ff4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/tools/codestyle/cpplint_pre_commit.hook b/tools/codestyle/cpplint_pre_commit.hook
@@ -1,10 +1,15 @@
 #!/bin/bash
 
 TOTAL_ERRORS=0
+
+readonly VERSION="1.6.0"
+
+version=$(cpplint --version)
+
 if [[ ! $TRAVIS_BRANCH ]]; then
   # install cpplint on local machine.
-  if [[ ! $(which cpplint) ]]; then
-    pip install cpplint
+  if ! [[ $version == *"$VERSION"* ]]; then
+    pip install cpplint==1.6.0
   fi
   # diff files on local machine. 
   files=$(git diff --cached --name-status | awk '$1 != "D" {print $2}')

diff --git a/tools/codestyle/pylint_pre_commit.hook b/tools/codestyle/pylint_pre_commit.hook
@@ -10,7 +10,7 @@ readonly VERSION="2.12.0"
 version=$(pylint --version | grep 'pylint')
 
 if ! [[ $version == *"$VERSION"* ]]; then
-    pip install pylint==2.12.0 1>nul
+    pip install pylint==2.12.0
 fi
 
 # The trick to remove deleted files: https://stackoverflow.com/a/2413151