Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【code format check upgrade】 step3:cpplint #43175

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented Jun 2, 2022

PR types

Others

PR changes

Others

Describe

upgrade cpplint to 1.6.0, this will not affect the static_check CI result. Because this CI each time use a docker image not installing cpplint, which cause it always install cpplint of default newest version, and that is 1.6.0.
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 2, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@betterpig betterpig force-pushed the cpplint_upgrade branch 2 times, most recently from fed67f0 to 4d8e5a6 Compare June 2, 2022 11:53
@betterpig betterpig requested a review from luotao1 June 3, 2022 03:41
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 19b4ff4 into PaddlePaddle:develop Jun 6, 2022
@betterpig betterpig changed the title 【code format check upgrade】 step1:cpplint 【code format check upgrade】 step3:cpplint Jun 6, 2022
@betterpig betterpig deleted the cpplint_upgrade branch June 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants