Skip to content

Commit

Permalink
[Zero-Dim] Support p_norm/reduce_sum_p output 0D (#53421)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhwesky2010 authored May 8, 2023
1 parent e522ceb commit e4bf1a8
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 29 deletions.
3 changes: 0 additions & 3 deletions paddle/fluid/operators/prim_ops/reduce_sum_p_op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ class ReduceSumPrimOpShapeInference : public framework::InferShapeBase {
x_shape.erase(remove(x_shape.begin(), x_shape.end(), kDelFlag),
x_shape.end());
}
if (!keepdim && x_shape.size() == 0) {
x_shape.push_back(1);
}

PADDLE_GET(framework::VarDesc *, y_var_ptr)->SetShape(x_shape);
}
Expand Down
36 changes: 19 additions & 17 deletions paddle/phi/infermeta/unary.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2750,31 +2750,33 @@ void PNormInferMeta(const MetaTensor& x,
x_rank,
x_dim));

std::vector<int> reduce_dims;
std::vector<int> out_dim_vector;
if (asvector) {
reduce_dims.emplace_back(1);
if (keepdim) {
for (int i = 1; i < x_dim.size(); ++i) {
reduce_dims.emplace_back(1);
for (int i = 0; i < x_rank; ++i) {
out_dim_vector.emplace_back(1);
}
x_dim = phi::make_ddim(reduce_dims);
} else {
out_dim_vector = {};
}
} else {
if (axis < 0) axis = x_dim.size() + axis;
for (int i = 0; i < x_dim.size(); ++i) {
if (i != axis) reduce_dims.emplace_back(x_dim[i]);
}
if (reduce_dims.size() == 0) {
reduce_dims.emplace_back(1);
if (axis < 0) axis = axis + x_rank;
if (keepdim) {
for (int i = 0; i < x_dim.size(); ++i) {
if (i != axis) {
out_dim_vector.emplace_back(x_dim[i]);
} else {
out_dim_vector.emplace_back(1);
}
}
} else {
for (int i = 0; i < x_dim.size(); ++i) {
if (i != axis) out_dim_vector.emplace_back(x_dim[i]);
}
}
x_dim[axis] = 1;
}

if (keepdim) {
out->set_dims(x_dim);
} else {
out->set_dims(phi::make_ddim(reduce_dims));
}
out->set_dims(phi::make_ddim(out_dim_vector));
out->set_dtype(x.dtype());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def is_output_compatible(self, dist_op):

output_name = outputs[0]
output_var = dist_op.serial_op.block._var_recursive(output_name)
if output_var.shape != (1,):
if output_var.shape != ():
return False

return True
Expand Down
4 changes: 0 additions & 4 deletions python/paddle/fluid/tests/unittests/test_pairwise_distance.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@

def np_pairwise_distance(x, y, p=2.0, epsilon=1e-6, keepdim=False):
distance = np.linalg.norm(x - y + epsilon, ord=p, axis=-1, keepdims=keepdim)
# Paddle currently has not supported for 0-d Tensors, so even if keep_dim is False,
# and neither x nor y is batched, a Tensor of shape (1, ) is returned
if distance.ndim == 0:
distance = np.expand_dims(distance, axis=0)
return distance


Expand Down
12 changes: 11 additions & 1 deletion test/auto_parallel/test_dist_pnorm.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,19 @@ def check_program(self):
op_dist_attr = self.dist_context.get_op_dist_attr_for_program(op)
if op.type == "p_norm":
assert op_dist_attr.impl_type == "p_norm"
if op.type in ["p_norm", "p_norm_grad"]:
for input_attr in op_dist_attr.inputs_dist_attrs.values():
assert set(input_attr.dims_mapping) == {-1}
for output_attr in op_dist_attr.outputs_dist_attrs.values():
if len(output_attr.dims_mapping) == 0:
assert output_attr.dims_mapping == []
else:
assert set(output_attr.dims_mapping) == {-1}
if op.type == "p_norm_grad":
for input_attr in op_dist_attr.inputs_dist_attrs.values():
if len(input_attr.dims_mapping) == 0:
assert input_attr.dims_mapping == []
else:
assert set(input_attr.dims_mapping) == {-1}
for output_attr in op_dist_attr.outputs_dist_attrs.values():
assert set(output_attr.dims_mapping) == {-1}
if op.type == 'c_allgather':
Expand Down
3 changes: 1 addition & 2 deletions test/auto_parallel/test_prim_dist_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def init_prog(self):
self.tmp1 = paddle.static.data(name='tmp1', shape=[20], dtype='float')
self.tmp2 = paddle.static.data(name='tmp2', shape=[20], dtype='float')
self.batch_reduced = paddle.static.data(
name='batch_reduced', shape=[1], dtype='float'
name='batch_reduced', shape=[], dtype='float'
)
self.attrs = {}

Expand Down Expand Up @@ -108,7 +108,6 @@ def test_loss_and_grad_allreduce(self):
self.main_program, self.startup_program, [(self.w, self.w_grad)]
)
ops = dist_main_prog.global_block().ops

self.assertTrue(ops[1].type == "c_allreduce_sum")
self.assertTrue(ops[3].type == "c_allreduce_sum")

Expand Down
2 changes: 1 addition & 1 deletion test/autograd/test_primops.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
primops.reduce_sum,
randn(2, 3),
{'axis': (0, 1)},
(1,),
(),
'float64',
),
(
Expand Down

0 comments on commit e4bf1a8

Please sign in to comment.