Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zero-Dim] Support p_norm/reduce_sum_p output 0D #53421

Merged
merged 1 commit into from
May 8, 2023

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Apr 27, 2023

PR types

New features

PR changes

APIs

Description

Pcard-66984

支持以下OP输出0D:

1. reduce_sum_p
2. p_norm

@paddle-bot
Copy link

paddle-bot bot commented Apr 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 27, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 27, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

XiaoguangHu01
XiaoguangHu01 previously approved these changes Apr 28, 2023
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 6, 2023

Sorry to inform you that cdeb71d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] Support p-norm output 0D [Zero-Dim] Support p_norm/reduce_sum_p output 0D May 6, 2023
@zhwesky2010 zhwesky2010 force-pushed the p_norm_0d branch 6 times, most recently from 8bfb0af to 23898cf Compare May 8, 2023 08:07
JZ-LIANG
JZ-LIANG previously approved these changes May 8, 2023
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dist reduce_sum_p

zhaoyinglia
zhaoyinglia previously approved these changes May 8, 2023
Copy link
Contributor

@zhaoyinglia zhaoyinglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dist_p_norm

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit e4bf1a8 into PaddlePaddle:develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants