Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support mean,softmax_with_cross_entropy on Baidu Kunlun #27792

Merged
merged 3 commits into from
Oct 13, 2020
Merged

support mean,softmax_with_cross_entropy on Baidu Kunlun #27792

merged 3 commits into from
Oct 13, 2020

Conversation

yghstill
Copy link
Contributor

@yghstill yghstill commented Oct 9, 2020

PR types

New features

PR changes

OPs

Describe

support mean,softmax_with_cross_entropy on Baidu Kunlun

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 9, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

tink2123
tink2123 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@tink2123 tink2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen
Copy link
Contributor

精度设置ok

Xreki
Xreki approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change of atol and max_relative_error.

luotao1
luotao1 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op_test.py

@jerrywgz jerrywgz merged commit 70c8c31 into PaddlePaddle:develop Oct 13, 2020
@yghstill yghstill deleted the fix_kunlun branch October 14, 2020 02:01
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@yghstill @chen-zhiyu
support mean,softmax_with_cross_entropy on Baidu Kunlun (PaddlePaddle…
18a94a2 
…#27792)

* support mean,softmax_with_cross_entropy on Baidu Kunlun,test=kunlun

* fix unittests error,test=kunlun

* delete boost::get,test=kunlun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@Xreki Xreki Xreki approved these changes

@tink2123 tink2123 tink2123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yghstill @QingshuChen @luotao1 @Xreki @tink2123 @jerrywgz