Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace complex64/128 with complex template in cast Op #33019

Merged
merged 2 commits into from
May 21, 2021
Merged

replace complex64/128 with complex template in cast Op #33019

merged 2 commits into from
May 21, 2021

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented May 20, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  • replace with paddle.to_tensor and print.
  • fix the bug in cast OP when cast between complex64 and complex128 types, and add test cases.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MingMingShangTian MingMingShangTian changed the title replace complex64 and complex128 with complex template replace complex64/128 with complex template in cast Op May 21, 2021
chenwhql
chenwhql approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian merged commit 79d918d into PaddlePaddle:develop May 21, 2021
@MingMingShangTian MingMingShangTian deleted the template_p4 branch May 21, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingMingShangTian @chenwhql