[NPU] add one_hot_op_npu and tests #34258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qili93
requested changes
Jul 20, 2021
|
|
||
|
|
||
| @unittest.skipIf(not paddle.is_compiled_with_npu(), | ||
| "core is not compiled with NPU") |
There was a problem hiding this comment.
秋良在这个PR #34240 里面修改了，如果这个PR在秋良的PR之后合入的话，可以把这里的skipIf代码去掉。后面所有的class代码都一样可以去掉。
| self.outputs = {'Out': (out, x_lod)} | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output_with_place(paddle.NPUPlace(0), check_dygraph=False) |
There was a problem hiding this comment.
check_dygraph=False 删掉，后面的也是
There was a problem hiding this comment.
参考test_one_hot_op.py，删掉check_dygraph=False 会报错
ronny1996
changed the title
qili93
previously approved these changes
Jul 23, 2021
| self.outputs = {'Out': (out, x_lod)} | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output_with_place(paddle.NPUPlace(0), check_dygraph=False) |
zhiqiu
reviewed
Jul 26, 2021
| runner.SetType("OneHot") | ||
| .AddInput(transformed_in) | ||
| .AddInput(std::vector<int32_t>({static_cast<int32_t>(depth)})) | ||
| .AddInput(on_value) |
There was a problem hiding this comment.
To make code clear, maybe on_value and off_value can write like depth
phlrain
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add one_hot_op_npu and tests
ascend的one-hot算子支持out of range，类似cuda kernel实现