Unify the implementation of AlignedVector and simplify the codes of dropout and cast. #35373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
force-pushed
the
opt/aligned_vector
branch
from
6c146d8
to
c202180
Compare
Xreki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
AlignedVector类型的定义，主要用于CUDA中向量化的数据读写操作。这个PR将AlignedVector类型及其相关的操作移动到一个独立的文件aligned_vector.h中，移除op中冗余的AlignedVector。AlignedVector实现了一个Load、Store操作，避免在代码中指针的反复显式调用reinterpret_cast。