add maximum limit for grid of reduce, elementwise and masked_select kernel #37355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
|
|
Thanks for your contribution! |
FlyingQianMM
changed the title
FlyingQianMM
changed the title
FlyingQianMM
force-pushed
the
develop_reduce
branch
from
1f86880
to
cf4c578
Compare
thisjiang
reviewed
Nov 19, 2021
|
Sorry to inform you that df043ba's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
FlyingQianMM
force-pushed
the
develop_reduce
branch
from
ffc7d33
to
29e0739
Compare
FlyingQianMM
force-pushed
the
develop_reduce
branch
2 times, most recently
from
2ea4b95
to
716c0fe
Compare
FlyingQianMM
force-pushed
the
develop_reduce
branch
from
716c0fe
to
36e856a
Compare
|
该pr已经重新提到pr #38903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
The grid number of reduce、elementwise and masked_select has not been limited, which may raise a bug like:
So we add a maximum limit for grid of reduce, elementwise and masked_select kernel.