-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add maximum limit for grid of reduce, elementwise and masked_select kernel #38903
Closed
FlyingQianMM
wants to merge
18
commits into
PaddlePaddle:develop
from
FlyingQianMM:develop_reduce_new
Closed
[WIP] add maximum limit for grid of reduce, elementwise and masked_select kernel #38903
FlyingQianMM
wants to merge
18
commits into
PaddlePaddle:develop
from
FlyingQianMM:develop_reduce_new
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
FlyingQianMM
force-pushed
the
develop_reduce_new
branch
from
January 12, 2022 11:59
f679bbf
to
7d91e3c
Compare
Sorry to inform you that 7d91e3c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sorry to inform you that 6073788's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
FlyingQianMM
changed the title
add maximum limit for grid of reduce, elementwise and masked_select kernel
[WIP] add maximum limit for grid of reduce, elementwise and masked_select kernel
Feb 17, 2022
… develop_reduce_new
… develop_reduce_new
… develop_reduce_new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
The grid number of reduce、elementwise and masked_select has not been limited, which may raise a bug like:
So we add a maximum limit for grid of reduce, elementwise and masked_select kernel.
该pr已经拆成三个pr合入:
1、add maximum limit for grid of reduce, elementwise, gather and scatter: https://github.com/PaddlePaddle/Paddle/pull/40813/files
2、support get_item where the index is a bool scalar tensor: #40829
3、support gather when index is 0-zero shape: #40952