Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move selected_rows PR #4] SelectedRows inherits from TensorBase. #39162

Merged

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Jan 24, 2022

PR types

Others

PR changes

Others

Describe

A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.

PR 1: Renamed selected_rows.* to selected_rows_utils.* PR39037
PR 2: Added selected_rows.* and rw_lock.h to Pten PR39087
PR 3: Change the relationship of [include/Cmake. PR39128

  1. Delete Class SelectedRows in selected_rows_utils.* under Fluid, leaving only a few serialization methods;
  2. Modify the [include/cmake] relationship;
  3. Use pten::SelectedRows in Fluid;
  4. Remove rw_lock.h, rw_lock_test.cc in Fluid;

This is PR4:

Selected_Rows inherits from TensorBase.

follow-up work:

PR 5: VisitDataType -> Pten::DataType.

@veyron95 veyron95 changed the title [Move selected_rows PR #3] Selected_Rows inherits from TensorBase. [Move selected_rows PR #4] Selected_Rows inherits from TensorBase. Jan 24, 2022
@veyron95 veyron95 changed the title [Move selected_rows PR #4] Selected_Rows inherits from TensorBase. [Move selected_rows PR #4] SelectedRows inherits from TensorBase. Jan 24, 2022
@veyron95 veyron95 merged commit 3e80253 into PaddlePaddle:develop Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants