-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move selected_rows PR #4] SelectedRows inherits from TensorBase. #39162
Merged
veyron95
merged 22 commits into
PaddlePaddle:develop
from
veyron95:fluid_move_selected_rows_to_pten_4
Jan 26, 2022
Merged
[Move selected_rows PR #4] SelectedRows inherits from TensorBase. #39162
veyron95
merged 22 commits into
PaddlePaddle:develop
from
veyron95:fluid_move_selected_rows_to_pten_4
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip, use pten::SelectedRows in Fluid
…e/Paddle into fluid_move_selected_rows_to_pten_4
veyron95
changed the title
[Move selected_rows PR #3] Selected_Rows inherits from TensorBase.
[Move selected_rows PR #4] Selected_Rows inherits from TensorBase.
Jan 24, 2022
veyron95
changed the title
[Move selected_rows PR #4] Selected_Rows inherits from TensorBase.
[Move selected_rows PR #4] SelectedRows inherits from TensorBase.
Jan 24, 2022
chenwhql
approved these changes
Jan 26, 2022
jim19930609
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.
PR 1: Renamed selected_rows.* to selected_rows_utils.* PR39037
PR 2: Added selected_rows.* and rw_lock.h to Pten PR39087
PR 3: Change the relationship of [include/Cmake. PR39128
This is PR4:
Selected_Rows inherits from TensorBase.
follow-up work:
PR 5: VisitDataType -> Pten::DataType.