-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move selected_rows PR #5] VisitDataType use Pten::DataType #39236
[Move selected_rows PR #5] VisitDataType use Pten::DataType #39236
Conversation
…ip, use pten::SelectedRows in Fluid
…e/Paddle into fluid_move_selected_rows_to_pten_4
…e/Paddle into fluid_move_selected_rows_to_pten_4
…e/Paddle into fluid_move_selected_rows_to_pten_4
… fluid_move_selected_rows_to_pten_4
… fluid_move_selected_rows_to_pten_4
… fluid_move_selected_rows_to_pten_5
… fluid_move_selected_rows_to_pten_5
Thanks for your contribution! |
callback, ::paddle::platform::complex<double>, DataType::COMPLEX128); | ||
|
||
template <typename Visitor> | ||
inline void VisitDataType(pten::DataType type, Visitor visitor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同步一下,这个VisitDataType我们认为写得不是很直观,之前讨论过说希望用switch-case的形式替换掉的,参考pten/api/ext/dispatch.h,不过短时间内好像也比较困难;
此外,后续如果还是有其他kernel使用,我们可能会考虑把这段实现直接放到common/data_type.h中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,后续再替换或者进一步优化,多谢。
PR types
Others
PR changes
Others
Describe
A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.
PR 1: Renamed selected_rows.* to selected_rows_utils.* PR39037
PR 2: Added selected_rows.* and rw_lock.h to Pten PR39087
PR 3: Change the relationship of [include/Cmake]. PR39128
PR 4: Selected_Rows inherits from TensorBase. PR39162
This is PR5:
PR 5: VisitDataType use Pten::DataType
(Part of func in framework/data_type.h are rewritten in pten/core/utils/data_type.h)