【code format check upgrade】 step2：cmake-format #43057
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
betterpig
changed the title
| - id: cmake-format | ||
| exclude: | | ||
| (?x)^( | ||
| paddle/fluid/operators/CMakeLists.txt |
There was a problem hiding this comment.
该文件格式化之后inference流水线报错，原因为tools/remove_grad_op_and_kernel.py需要对该文件进行修改，格式化后读取该文件出错。
报错截图：
tools/remove_grad_op_and_kernel.py代码截图：
There was a problem hiding this comment.
明白了，remove_grad_op_and_kernel.py 是推理用来裁剪反向Op的，可以后续看下如何格式化
CMakeLists.txt
Outdated
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License |
There was a problem hiding this comment.
考虑到注释一般都是已经排好版的，只要极少数注释会具有列宽超限问题，因此决定不对注释进行格式化，对于注释的把控主要靠开发同学自身，以及cmakelint对于列宽超限提示的辅助。
已通过在.cmake-format.py里设置 enable_markup = False 屏蔽掉对注释的格式化。
cmake/cblas.cmake
Outdated
| # CBLAS_INC_DIR # the include directory for cblas. | ||
| # CBLAS_LIBS # a list of libraries should be linked by paddle. | ||
| # # Each library should be full path to object file. | ||
| # CBLAS_PROVIDER # one of MKLML, OPENBLAS, REFERENCE CBLAS_INC_DIR # the |
|
2022-06-03 11:39:23 3. You must be approved by chenwhql or zyfncg for paddle/phi/kernels/declarations.h using. Thanks! |
PR types
Others
PR changes
Others
Describe
add cmake-format to help format cmake files.
some points:
before:
after:
paddle/fluid/operators/CMakeLists.txt, because tools/remove_grad_op_and_kernel.py need to update it, and errors occured after format this file, so just let it keep original format.