-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【code format check upgrade】 step2：cmake-format #43057
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # ----------------------------- | ||
| # Options affecting formatting. | ||
| # ----------------------------- | ||
| with section("format"): | ||
|
|
||
| # How wide to allow formatted cmake files | ||
| line_width = 80 | ||
|
|
||
| # ------------------------------------------------ | ||
| # Options affecting comment reflow and formatting. | ||
| # ------------------------------------------------ | ||
| with section("markup"): | ||
| # enable comment markup parsing and reflow | ||
| enable_markup = False | ||
|
|
||
| # If comment markup is enabled, don't reflow the first comment block in each | ||
| # listfile. Use this to preserve formatting of your copyright/license | ||
| # statements. | ||
| first_comment_is_literal = True | ||
|
|
||
| # ---------------------------------- | ||
| # Options affecting listfile parsing | ||
| # ---------------------------------- | ||
| with section("parse"): | ||
| # Additional FLAGS and KWARGS for custom commands | ||
| additional_commands = { | ||
| "cc_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "nv_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "hip_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "xpu_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "hip_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "hip_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "go_library": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "copy": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DSTS": '*', | ||
| } | ||
| }, | ||
| "cc_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "nv_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "hip_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "xpu_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "go_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| }, | ||
| "py_test": { | ||
| "kwargs": { | ||
| "SRCS": '*', | ||
| "DEPS": '*', | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问这个exclude是有什么考虑么？后面会移走么？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该文件格式化之后inference流水线报错，原因为tools/remove_grad_op_and_kernel.py需要对该文件进行修改，格式化后读取该文件出错。
报错截图：
tools/remove_grad_op_and_kernel.py代码截图：
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
明白了，remove_grad_op_and_kernel.py 是推理用来裁剪反向Op的，可以后续看下如何格式化